Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow justification for "No chart changes detected" fast end #49

Closed
cep21 opened this issue Sep 23, 2020 · 1 comment
Closed

Workflow justification for "No chart changes detected" fast end #49

cep21 opened this issue Sep 23, 2020 · 1 comment

Comments

@cep21
Copy link

cep21 commented Sep 23, 2020

Hi,

I'm unsure why "No chart changes detected" fast stop is the best workflow. Can you talk about this more? We put our helm charts with our service code. Other people do that to (flux is one example: https://github.com/fluxcd/flux/tree/master/chart)

It makes sense to me to try starting and testing our helm chart on every PR. We may only modify the helm chart version infrequently, but we would want to know on each PR if the code will break the helm chart. I imagine this would be the desired workflow for most people. I'm maybe misunderstanding something about why this would be undesired or not want to be the default.

I imagine this is related to #12

@cpanato
Copy link
Member

cpanato commented Sep 27, 2022

this is explained here #12 (comment)

@cpanato cpanato closed this as completed Sep 27, 2022
ghost pushed a commit to OMB-MOD/chart-testing-action that referenced this issue Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants