[tensorflow inception] add stable image and tag, fix gpu usage (#6698)

* [tensorflow inception] add stable image and tag, fix gpu usage * fixing lint warnings, update github user names * Update values.yaml
helm · Jul 26, 2018 · f39d73d · f39d73d
1 parent 393d869
commit f39d73d
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 12 deletions.
diff --git a/incubator/tensorflow-inception/Chart.yaml b/incubator/tensorflow-inception/Chart.yaml
@@ -1,13 +1,14 @@
 name: tensorflow-inception
 home: https://github.com/kubernetes/charts
-version: 0.3.0
+version: 0.4.0
 appVersion: 1.4.0
-description: Open source software library for numerical computation using data flow
-  graphs.
+description: Open source software library for numerical computation using data flow graphs.
 icon: https://camo.githubusercontent.com/ee91ac3c9f5ad840ebf70b54284498fe0e6ddb92/68747470733a2f2f7777772e74656e736f72666c6f772e6f72672f696d616765732f74665f6c6f676f5f7472616e73702e706e67
 sources:
 - https://github.com/tensorflow/
 - https://tensorflow.github.io/serving/serving_inception.html
 maintainers:
-- name: Lachlan Evenson
+- name: lachie83
   email: lachlan.evenson@gmail.com
+- name: thomasjungblut
+  email: thomas.jungblut@gmail.com
diff --git a/incubator/tensorflow-inception/README.md b/incubator/tensorflow-inception/README.md
@@ -27,8 +27,8 @@ The following table lists the configurable parameters of the TensorFlow inceptio
 
 | Parameter               | Description                        | Default                                                    |
 | ----------------------- | ---------------------------------- | ---------------------------------------------------------- |
-| `image`          | Container image name               | `quay.io/lachie83/inception_serving`                              |
-| `imageTag`       | Container image tag                | `latest`                                                          |
+| `image.repository`          | Container image name               | `quay.io/thomasjungblut/tfs-inception`                              |
+| `image.tag`       | Container image tag                | `tfs-1.8.0-gpu`                                                          |
 | `replicas`       | k8s deployment replicas            | `1`                                                               |
 | `component`      | k8s selector key                   | `tensorflow-inception`                                            |
 | `resources`      | Set the resource to be allocated and allowed for the Pods                   | `{}`                                            |

diff --git a/incubator/tensorflow-inception/templates/tensorflow-inception.yaml b/incubator/tensorflow-inception/templates/tensorflow-inception.yaml
@@ -46,13 +46,18 @@ spec:
     spec:
       containers:
         - name: {{ template "tensorflow-inception.fullname" . }}
-          image: "{{ .Values.image }}:{{ .Values.imageTag }}"
-          imagePullPolicy: "{{ .Values.imagePullPolicy }}"
+          image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
+          imagePullPolicy: "{{ .Values.image.pullPolicy }}"
           command:
           - "/bin/sh"
           - "-c"
           args:
-          - "/serving/bazel-bin/tensorflow_serving/model_servers/tensorflow_model_server --port={{ .Values.containerPort }} --model_name=inception --model_base_path=/serving/inception-export"
+          - "tensorflow_model_server --port={{ .Values.containerPort }} --model_name=inception --model_base_path=/serving/inception-export"
+{{- if .Values.env.ldLibraryPath  }}
+          env:
+          - name: LD_LIBRARY_PATH
+            value: {{ .Values.env.ldLibraryPath }}
+{{ end }}
           ports:
             - containerPort: {{ .Values.containerPort }}
           readinessProbe:

diff --git a/incubator/tensorflow-inception/values.yaml b/incubator/tensorflow-inception/values.yaml
@@ -8,9 +8,14 @@ servicePort: 9090
 containerPort: 9090
 component: "tensorflow-inception"
 replicas: 1
-image: "quay.io/lachie83/inception_serving"
-imageTag: "latest"
-imagePullPolicy: "IfNotPresent"
+image:
+  repository: "quay.io/thomasjungblut/tfs-inception"
+  tag: "tfs-1.8.0-gpu"
+  pullPolicy: "IfNotPresent"
+
+env:
+  ldLibraryPath: "/usr/lib/x86_64-linux-gnu/"
+
 resources: {}
 #  limits:
 #    nvidia.com/gpu: 1