[stable/concourse] Creation of worker-only releases #11280

cirocosta · 2019-02-08T15:32:43Z

Being a common scenario to have people providing their own set of workers to join a totally separate Concourse cluster, it'd be interesting if we supported this use case by allowing one to have a "workers-only" deployment.

web:
  enabled: false

workers:
  replicas: 2
  enabled: true
  nodeSelector: # ...
  # ...

concourse:
  worker:
    tag: 'high-cpu'
    tsa:
      host: concourse-web.namespace-example.svc.cluster.local:22
      # ...

Disabling web would then not create the web-related objects. This would mean that we'd need to soften the requirements we have around some values that are provided.

In the future, we could also think about the case of allowing the creation of multiple types of workers under a single release too, but that might better fit a different issue.

Wdyt?

Thx!

cc @william-tran

The text was updated successfully, but these errors were encountered:

stale · 2019-03-10T16:24:24Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

cirocosta · 2019-03-10T22:55:48Z

🙌

william-tran · 2019-03-13T16:10:02Z

Yes, I see this along with #12056 as the way forward for harder multitenancy

YoussB · 2019-04-08T21:19:28Z

We created a PR for Helm and Concourse to fix this issue.

The end result of the current PR is that you can now make worker-only deployments.

Regarding the privileged container topic mentioned here: #12056 (comment)
should we make a new issue for this or continue it within this current issue?

* stable/concourse: separate worker, web deployments - Added .Values.Web.enabled and .Values.worker.enabled (with default to true). - if only .Values.web.enable is enabled: only web resources are going to be created, as well as secrets namespace. - if only .Values.worker.enable is enabled: only worker resources are going to be created. - moved the worker specific and web specific secrets each to a seprate file and secrets object. - added .Values.concourse.worker.tsa.port and utilised .Values.concourse.worker.host in order to alow the user to set the `CONCOURSE_TSA_HOST` easily. - removed the template `concourse.concourse.fullname` as it is not used anymore. - bumped the chart version to 6.0.0, as this adds new ways to use the chart. - added the new variables to the README doc. for the issue: #11280 Signed-off-by: Taylor Silva <tsilva@pivotal.io> Co-authored-by: Bishoy Youssef <byoussef@pivotal.io> Signed-off-by: Taylor Silva <tsilva@pivotal.io> * [stable/concourse] bumping chart version and updating the Readme Signed-off-by: Taylor Silva <tsilva@pivotal.io> Co-authored-by: Bishoy Youssef <byoussef@pivotal.io> * Adds a required check yaml for having either the web or worker enabled Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * Adds required for concourse.worker.tsa in case of worker only deployments Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * updates readme Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * adds changelog file Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * Apply suggestions from code review Signed-off-by: Bishoy Youssef <byoussef@pivotal.io>

* stable/concourse: separate worker, web deployments - Added .Values.Web.enabled and .Values.worker.enabled (with default to true). - if only .Values.web.enable is enabled: only web resources are going to be created, as well as secrets namespace. - if only .Values.worker.enable is enabled: only worker resources are going to be created. - moved the worker specific and web specific secrets each to a seprate file and secrets object. - added .Values.concourse.worker.tsa.port and utilised .Values.concourse.worker.host in order to alow the user to set the `CONCOURSE_TSA_HOST` easily. - removed the template `concourse.concourse.fullname` as it is not used anymore. - bumped the chart version to 6.0.0, as this adds new ways to use the chart. - added the new variables to the README doc. for the issue: helm#11280 Signed-off-by: Taylor Silva <tsilva@pivotal.io> Co-authored-by: Bishoy Youssef <byoussef@pivotal.io> Signed-off-by: Taylor Silva <tsilva@pivotal.io> * [stable/concourse] bumping chart version and updating the Readme Signed-off-by: Taylor Silva <tsilva@pivotal.io> Co-authored-by: Bishoy Youssef <byoussef@pivotal.io> * Adds a required check yaml for having either the web or worker enabled Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * Adds required for concourse.worker.tsa in case of worker only deployments Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * updates readme Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * adds changelog file Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * Apply suggestions from code review Signed-off-by: Bishoy Youssef <byoussef@pivotal.io>

* stable/concourse: separate worker, web deployments - Added .Values.Web.enabled and .Values.worker.enabled (with default to true). - if only .Values.web.enable is enabled: only web resources are going to be created, as well as secrets namespace. - if only .Values.worker.enable is enabled: only worker resources are going to be created. - moved the worker specific and web specific secrets each to a seprate file and secrets object. - added .Values.concourse.worker.tsa.port and utilised .Values.concourse.worker.host in order to alow the user to set the `CONCOURSE_TSA_HOST` easily. - removed the template `concourse.concourse.fullname` as it is not used anymore. - bumped the chart version to 6.0.0, as this adds new ways to use the chart. - added the new variables to the README doc. for the issue: helm/charts#11280 Signed-off-by: Taylor Silva <tsilva@pivotal.io> Co-authored-by: Bishoy Youssef <byoussef@pivotal.io> Signed-off-by: Taylor Silva <tsilva@pivotal.io> * [stable/concourse] bumping chart version and updating the Readme Signed-off-by: Taylor Silva <tsilva@pivotal.io> Co-authored-by: Bishoy Youssef <byoussef@pivotal.io> * Adds a required check yaml for having either the web or worker enabled Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * Adds required for concourse.worker.tsa in case of worker only deployments Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * updates readme Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * adds changelog file Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * Apply suggestions from code review Signed-off-by: Bishoy Youssef <byoussef@pivotal.io>

* stable/concourse: separate worker, web deployments - Added .Values.Web.enabled and .Values.worker.enabled (with default to true). - if only .Values.web.enable is enabled: only web resources are going to be created, as well as secrets namespace. - if only .Values.worker.enable is enabled: only worker resources are going to be created. - moved the worker specific and web specific secrets each to a seprate file and secrets object. - added .Values.concourse.worker.tsa.port and utilised .Values.concourse.worker.host in order to alow the user to set the `CONCOURSE_TSA_HOST` easily. - removed the template `concourse.concourse.fullname` as it is not used anymore. - bumped the chart version to 6.0.0, as this adds new ways to use the chart. - added the new variables to the README doc. for the issue: helm#11280 Signed-off-by: Taylor Silva <tsilva@pivotal.io> Co-authored-by: Bishoy Youssef <byoussef@pivotal.io> Signed-off-by: Taylor Silva <tsilva@pivotal.io> * [stable/concourse] bumping chart version and updating the Readme Signed-off-by: Taylor Silva <tsilva@pivotal.io> Co-authored-by: Bishoy Youssef <byoussef@pivotal.io> * Adds a required check yaml for having either the web or worker enabled Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * Adds required for concourse.worker.tsa in case of worker only deployments Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * updates readme Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * adds changelog file Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * Apply suggestions from code review Signed-off-by: Bishoy Youssef <byoussef@pivotal.io>

* stable/concourse: separate worker, web deployments - Added .Values.Web.enabled and .Values.worker.enabled (with default to true). - if only .Values.web.enable is enabled: only web resources are going to be created, as well as secrets namespace. - if only .Values.worker.enable is enabled: only worker resources are going to be created. - moved the worker specific and web specific secrets each to a seprate file and secrets object. - added .Values.concourse.worker.tsa.port and utilised .Values.concourse.worker.host in order to alow the user to set the `CONCOURSE_TSA_HOST` easily. - removed the template `concourse.concourse.fullname` as it is not used anymore. - bumped the chart version to 6.0.0, as this adds new ways to use the chart. - added the new variables to the README doc. for the issue: helm/charts#11280 Signed-off-by: Taylor Silva <tsilva@pivotal.io> Co-authored-by: Bishoy Youssef <byoussef@pivotal.io> Signed-off-by: Taylor Silva <tsilva@pivotal.io> * [stable/concourse] bumping chart version and updating the Readme Signed-off-by: Taylor Silva <tsilva@pivotal.io> Co-authored-by: Bishoy Youssef <byoussef@pivotal.io> * Adds a required check yaml for having either the web or worker enabled Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * Adds required for concourse.worker.tsa in case of worker only deployments Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * updates readme Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * adds changelog file Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> * Apply suggestions from code review Signed-off-by: Bishoy Youssef <byoussef@pivotal.io>

stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 10, 2019

stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 10, 2019

YoussB mentioned this issue Mar 13, 2019

[stable/concourse] Easier way to add team external workers #12056

Merged

3 tasks

YoussB mentioned this issue Apr 8, 2019

stable/concourse: separate worker, web deployments #12920

Merged

3 tasks

YoussB mentioned this issue Apr 9, 2019

[stable/concourse] Provide a changelog that communicate our changes #11512

Closed

k8s-ci-robot closed this as completed in #12920 Apr 25, 2019

aegershman mentioned this issue Jun 17, 2019

[concourse/stable] Concourse worker name should have worker number in hostname #14868

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable/concourse] Creation of worker-only releases #11280

[stable/concourse] Creation of worker-only releases #11280

cirocosta commented Feb 8, 2019 •

edited

Loading

stale bot commented Mar 10, 2019

cirocosta commented Mar 10, 2019

william-tran commented Mar 13, 2019

YoussB commented Apr 8, 2019

[stable/concourse] Creation of worker-only releases #11280

[stable/concourse] Creation of worker-only releases #11280

Comments

cirocosta commented Feb 8, 2019 • edited Loading

stale bot commented Mar 10, 2019

cirocosta commented Mar 10, 2019

william-tran commented Mar 13, 2019

YoussB commented Apr 8, 2019

cirocosta commented Feb 8, 2019 •

edited

Loading