Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/concourse] Investigate and remove mounting workerKeyPub inside the worker pod #13019

Closed
YoussB opened this issue Apr 12, 2019 · 5 comments · Fixed by #15579
Closed

[stable/concourse] Investigate and remove mounting workerKeyPub inside the worker pod #13019

YoussB opened this issue Apr 12, 2019 · 5 comments · Fixed by #15579

Comments

@YoussB
Copy link
Collaborator

YoussB commented Apr 12, 2019

Version of Helm and Kubernetes:
latest

Which chart:
stable/concourse

What happened:

  • the workerKeyPub is mounted on the worker pod, although, technically this is not needed.

What you expected to happen:

  • the workerKeyPub should not be mounted on the worker pod.

How to reproduce it (as minimally and precisely as possible):

  • helm install the chart
@YoussB YoussB mentioned this issue Apr 12, 2019
Merged
3 tasks
@stale
Copy link

stale bot commented May 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2019
@YoussB
Copy link
Collaborator Author

YoussB commented May 13, 2019

🙌

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2019
@stale
Copy link

stale bot commented Jun 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 12, 2019
@cirocosta
Copy link
Collaborator

👀

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2019
@YoussB YoussB mentioned this issue Jul 16, 2019
Merged
3 tasks
@YoussB
Copy link
Collaborator Author

YoussB commented Jul 18, 2019

awaiting the merge of:

gypsydiver pushed a commit to gypsydiver/charts that referenced this issue Jul 25, 2019
@YoussB @gypsydiver
stable/concourse: remove workerKeyPub from worker secrets (helm#15579)
6bdbb00 
- removed references to the worker public key from the worker deployment
- on the Concourse side, added more tests to make sure this is not used
anywhere (see: concourse/concourse#4133)

fixes: helm#13019

Signed-off-by: Zoe Tian <ztian@pivotal.io>
Co-authored-by: Bishoy Youssef <byoussef@pivotal.io>
Co-authored-by: Ciro S. Costa <cscosta@pivotal.io>
ThoTischner pushed a commit to bitsbeats/charts that referenced this issue Aug 13, 2019
@YoussB
stable/concourse: remove workerKeyPub from worker secrets (helm#15579)
6269e0d 
- removed references to the worker public key from the worker deployment
- on the Concourse side, added more tests to make sure this is not used
anywhere (see: concourse/concourse#4133)

fixes: helm#13019

Signed-off-by: Zoe Tian <ztian@pivotal.io>
Co-authored-by: Bishoy Youssef <byoussef@pivotal.io>
Co-authored-by: Ciro S. Costa <cscosta@pivotal.io>
landorg pushed a commit to landorg/charts that referenced this issue Aug 19, 2019
@YoussB @landorg
stable/concourse: remove workerKeyPub from worker secrets (helm#15579)
c634d19 
- removed references to the worker public key from the worker deployment
- on the Concourse side, added more tests to make sure this is not used
anywhere (see: concourse/concourse#4133)

fixes: helm#13019

Signed-off-by: Zoe Tian <ztian@pivotal.io>
Co-authored-by: Bishoy Youssef <byoussef@pivotal.io>
Co-authored-by: Ciro S. Costa <cscosta@pivotal.io>
Signed-off-by: Roland Gritzer <gritzer.roland@gmail.com>
kengou pushed a commit to kengou/charts that referenced this issue Sep 18, 2019
@YoussB @kengou
stable/concourse: remove workerKeyPub from worker secrets (helm#15579)
8069ddc 
- removed references to the worker public key from the worker deployment
- on the Concourse side, added more tests to make sure this is not used
anywhere (see: concourse/concourse#4133)

fixes: helm#13019

Signed-off-by: Zoe Tian <ztian@pivotal.io>
Co-authored-by: Bishoy Youssef <byoussef@pivotal.io>
Co-authored-by: Ciro S. Costa <cscosta@pivotal.io>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this issue Sep 30, 2019
@YoussB
stable/concourse: remove workerKeyPub from worker secrets (helm#15579)
f6ed1cf 
- removed references to the worker public key from the worker deployment
- on the Concourse side, added more tests to make sure this is not used
anywhere (see: concourse/concourse#4133)

fixes: helm#13019

Signed-off-by: Zoe Tian <ztian@pivotal.io>
Co-authored-by: Bishoy Youssef <byoussef@pivotal.io>
Co-authored-by: Ciro S. Costa <cscosta@pivotal.io>
gaida pushed a commit to gaida/charts that referenced this issue Oct 3, 2019
@YoussB @gaida
stable/concourse: remove workerKeyPub from worker secrets (helm#15579)
5b61dbd 
- removed references to the worker public key from the worker deployment
- on the Concourse side, added more tests to make sure this is not used
anywhere (see: concourse/concourse#4133)

fixes: helm#13019

Signed-off-by: Zoe Tian <ztian@pivotal.io>
Co-authored-by: Bishoy Youssef <byoussef@pivotal.io>
Co-authored-by: Ciro S. Costa <cscosta@pivotal.io>
taylorsilva added a commit to concourse/concourse-chart that referenced this issue Jan 20, 2020
@taylorsilva
Update secrets generation section of README
5144963 
Fixes #48 by adding the Concourse binary method as the first way of
generating secrets. Updates the ssh-keygen method by adding the `-m`
flag to specify what format the key needs to be in.

Removed a reference to this issue:
helm/charts#13019

Issue was fixed and therefore not relevant to the chart anymore.

Signed-off-by: Taylor Silva <tsilva@pivotal.io>
@taylorsilva taylorsilva mentioned this issue Jan 20, 2020
Merged
xtremerui pushed a commit to concourse/concourse-chart that referenced this issue Mar 26, 2020
@taylorsilva
Update secrets generation section of README
af2517e 
Fixes #48 by adding the Concourse binary method as the first way of
generating secrets. Updates the ssh-keygen method by adding the `-m`
flag to specify what format the key needs to be in.

Removed a reference to this issue:
helm/charts#13019

Issue was fixed and therefore not relevant to the chart anymore.

Signed-off-by: Taylor Silva <tsilva@pivotal.io>
xtremerui pushed a commit to concourse/concourse-chart that referenced this issue Mar 26, 2020
@taylorsilva
Update secrets generation section of README
78e49ed 
Fixes #48 by adding the Concourse binary method as the first way of
generating secrets. Updates the ssh-keygen method by adding the `-m`
flag to specify what format the key needs to be in.

Removed a reference to this issue:
helm/charts#13019

Issue was fixed and therefore not relevant to the chart anymore.

Signed-off-by: Taylor Silva <tsilva@pivotal.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[stable/concourse] #13019 remove workerKeyPub from worker statefulset
2 participants
@cirocosta @YoussB