Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[Concourse] Vault Auth Param should be treated as a secret #8093

Closed
chrishiestand opened this issue Oct 1, 2018 · 2 comments · Fixed by #8094
Closed

[Concourse] Vault Auth Param should be treated as a secret #8093

chrishiestand opened this issue Oct 1, 2018 · 2 comments · Fixed by #8094

Comments

@chrishiestand
Copy link
Contributor

Is this a request for help?:
No


Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Bug Report

In the recently merged large PR #7804, the vault auth param was moved from a pair of secrets (Values.secrets.vaultAppRoleId,Values.secrets.vaultAppRoleSecretId) into a chart value (concourse.web.vault.authParam) that doesn't have a corresponding entry in secrets.yaml.

But since CONCOURSE_VAULT_AUTH_PARAM is supposed to be used to pass secret credentials, the helm chart should treat them as secret credentials - and allow keeping them out of helm/tiller.

@stale
Copy link

stale bot commented Nov 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 1, 2018
@chrishiestand
Copy link
Contributor Author

Just waiting on merge.

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant