This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Cluster autoscaler clusterrole add jobs #10206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/S
helm-bot
added
Contribution Allowed
|
/ok-to-test |
|
@plumdog can you rebase ? |
Signed-off-by: Andrew Plummer <plummer574@gmail.com>
Signed-off-by: Andrew Plummer <plummer574@gmail.com>
helm-bot
added
size/S
Signed-off-by: Andrew Plummer <plummer574@gmail.com>
helm-bot
added
size/S
|
@cpanato Rebased and version number re-bumped. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, plumdog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
thanks so much for your contribution @plumdog |
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
* [cluster-autoscaler] Add batch.jobs permissions to clusterrole Signed-off-by: Andrew Plummer <plummer574@gmail.com> * [cluster-autoscaler] Cronjobs too Signed-off-by: Andrew Plummer <plummer574@gmail.com> * [cluster-autoscaler] Bump version number Signed-off-by: Andrew Plummer <plummer574@gmail.com>
victorboissiere
pushed a commit
to victorboissiere/charts
that referenced
this pull request
Jan 24, 2019
* [cluster-autoscaler] Add batch.jobs permissions to clusterrole Signed-off-by: Andrew Plummer <plummer574@gmail.com> * [cluster-autoscaler] Cronjobs too Signed-off-by: Andrew Plummer <plummer574@gmail.com> * [cluster-autoscaler] Bump version number Signed-off-by: Andrew Plummer <plummer574@gmail.com> Signed-off-by: Victor Boissiere <victor.boissiere@neo9.fr>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mgoodness
I got an error that looked like:
So the cluster autoscaler is trying to get jobs but the clusterrole won't let it. Adding the permission rule for
batch.jobsmade this error go away and the autoscaler worked again.Have also added
cronjobsto match with kubernetes/autoscaler#1189, though I have not found a canonical set of required permissions for the cluster-autoscaler.