This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/prometheus-operator] Resolve scraping controller-manager and scheduler outside out the cluster #10366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scheduler outside out the cluster Signed-off-by: Sébastien Prud'homme <sebastien.prudhomme@gmail.com>
helm-bot
added
Contribution Allowed
|
/assign @gianrubio |
k8s-ci-robot
added
ok-to-test
lgtm
helm-bot
added
size/M
|
/retest |
helm-bot
added
size/M
Signed-off-by: Sébastien Prud'homme <sebastien.prudhomme@gmail.com>
Signed-off-by: Sébastien Prud'homme <sebastien.prudhomme@gmail.com>
helm-bot
added
size/M
|
/test pull-charts-e2e |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gianrubio, sebastien-prudhomme The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
…scheduler outside out the cluster (helm#10366) * [stable/prometheus-operator] Resolve scraping controller-manager and scheduler outside out the cluster Signed-off-by: Sébastien Prud'homme <sebastien.prudhomme@gmail.com> * [stable/prometheus-operator] Bump version Signed-off-by: Sébastien Prud'homme <sebastien.prudhomme@gmail.com>
hakamadare
pushed a commit
to hakamadare/charts
that referenced
this pull request
Jan 29, 2019
…scheduler outside out the cluster (helm#10366) * [stable/prometheus-operator] Resolve scraping controller-manager and scheduler outside out the cluster Signed-off-by: Sébastien Prud'homme <sebastien.prudhomme@gmail.com> * [stable/prometheus-operator] Bump version Signed-off-by: Sébastien Prud'homme <sebastien.prudhomme@gmail.com>
hakamadare
pushed a commit
to hakamadare/charts
that referenced
this pull request
Jan 29, 2019
…scheduler outside out the cluster (helm#10366) * [stable/prometheus-operator] Resolve scraping controller-manager and scheduler outside out the cluster Signed-off-by: Sébastien Prud'homme <sebastien.prudhomme@gmail.com> * [stable/prometheus-operator] Bump version Signed-off-by: Sébastien Prud'homme <sebastien.prudhomme@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sébastien Prud'homme sebastien.prudhomme@gmail.com
What this PR does / why we need it:
Bring back a way to define endpoints for controller-manager and scheduler when they are not installed in the cluster
Which issue this PR fixes
Special notes for your reviewer:
Checklist