This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/wordpress] Add service annotations #10498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>
helm-bot
added
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Jan 9, 2019
cpanato
reviewed
Jan 9, 2019
/ok-to-test |
/assign |
Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>
helm-bot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Jan 10, 2019
juan131
suggested changes
Jan 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your contribution! Please take a look to my comments.
Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>
helm-bot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Jan 10, 2019
juan131
approved these changes
Jan 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clalbus, juan131 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jan 10, 2019
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
* [stable/wordpress] Add service annotations Signed-off-by: Andrejs Volkovs <clalbus@gmail.com> * [stable/wordpress] Bump version to 5.1.0 Signed-off-by: Andrejs Volkovs <clalbus@gmail.com> * [stable/wordpress] Initialize service annotations in prod values Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>
hakamadare
pushed a commit
to hakamadare/charts
that referenced
this pull request
Jan 29, 2019
* [stable/wordpress] Add service annotations Signed-off-by: Andrejs Volkovs <clalbus@gmail.com> * [stable/wordpress] Bump version to 5.1.0 Signed-off-by: Andrejs Volkovs <clalbus@gmail.com> * [stable/wordpress] Initialize service annotations in prod values Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>
hakamadare
pushed a commit
to hakamadare/charts
that referenced
this pull request
Jan 29, 2019
* [stable/wordpress] Add service annotations Signed-off-by: Andrejs Volkovs <clalbus@gmail.com> * [stable/wordpress] Bump version to 5.1.0 Signed-off-by: Andrejs Volkovs <clalbus@gmail.com> * [stable/wordpress] Initialize service annotations in prod values Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
lgtm
Indicates that a PR is ready to be merged.
ok-to-test
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrejs Volkovs clalbus@gmail.com
What this PR does / why we need it:
Allows users to set service annotations.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]