Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/wordpress] Add service annotations #10498

Merged
merged 3 commits into from Jan 10, 2019
Merged

[stable/wordpress] Add service annotations #10498

merged 3 commits into from Jan 10, 2019

Conversation

clalbus
Copy link
Contributor

@clalbus clalbus commented Jan 9, 2019

Signed-off-by: Andrejs Volkovs clalbus@gmail.com

What this PR does / why we need it:

Allows users to set service annotations.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2019
stable/wordpress/Chart.yaml Outdated Show resolved Hide resolved
@cpanato
Copy link
Member

cpanato commented Jan 9, 2019

/ok-to-test

@cpanato
Copy link
Member

cpanato commented Jan 9, 2019

/assign

Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2019
Copy link
Collaborator

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution! Please take a look to my comments.

stable/wordpress/values.yaml Show resolved Hide resolved
Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2019
Copy link
Collaborator

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@juan131
Copy link
Collaborator

juan131 commented Jan 10, 2019

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clalbus, juan131

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit c5d0a35 into helm:master Jan 10, 2019
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
* [stable/wordpress] Add service annotations

Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>

* [stable/wordpress] Bump version to 5.1.0

Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>

* [stable/wordpress] Initialize service annotations in prod values

Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
* [stable/wordpress] Add service annotations

Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>

* [stable/wordpress] Bump version to 5.1.0

Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>

* [stable/wordpress] Initialize service annotations in prod values

Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>
hakamadare pushed a commit to hakamadare/charts that referenced this pull request Jan 29, 2019
* [stable/wordpress] Add service annotations

Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>

* [stable/wordpress] Bump version to 5.1.0

Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>

* [stable/wordpress] Initialize service annotations in prod values

Signed-off-by: Andrejs Volkovs <clalbus@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants