Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

cert-manager: fast-forward to upstream 9a8f4371 #10830

Merged
merged 1 commit into from
Jan 23, 2019
Merged

cert-manager: fast-forward to upstream 9a8f4371 #10830

merged 1 commit into from
Jan 23, 2019

Conversation

munnerz
Copy link
Collaborator

@munnerz munnerz commented Jan 22, 2019

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

/cc @kragniz

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2019
@munnerz munnerz force-pushed the automated-sync-release-0.6-master branch from c12ba87 to 7617292 Compare January 22, 2019 18:15
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2019
@munnerz
cert-manager: fast-forward to upstream 9a8f4371
7b96b5b 
* Bump version strings for v0.6.0 (cert-manager/cert-manager#1247)
* Set CA sync backoff limit & add verifying installation docs (cert-manager/cert-manager#1245)
* Added securityContext to cert-manager deployment pods in helm chart (cert-manager/cert-manager#1237)
* Move Helm chart to deploy/charts/cert-manager (cert-manager/cert-manager#1235)
* chart: allow deployment strategy customization
* webhook: remove hardcoded image (cert-manager/cert-manager#1039)
* Remove crd-install annotation from Challenges and Orders
* Add Challenge and Order CRDs
* Add certificates and issuers to aggregated RBAC for view, edit and admin ClusterRoles. (cert-manager/cert-manager#872)
* Use fixed image tag for ca-helper and add description

Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz munnerz force-pushed the automated-sync-release-0.6-master branch from 7617292 to 7b96b5b Compare January 22, 2019 18:21
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2019
@munnerz
Copy link
Collaborator Author

munnerz commented Jan 22, 2019

/retest

1 similar comment
@munnerz
Copy link
Collaborator Author

munnerz commented Jan 22, 2019

/retest

swade1987
swade1987 reviewed Jan 22, 2019
View reviewed changes
stable/cert-manager/templates/deployment.yaml
@@ -14,6 +14,10 @@ spec:
matchLabels:
app: {{ template "cert-manager.name" . }}
release: {{ .Release.Name }}
{{- with .Values.strategy }}
strategy:
{{- . | toYaml | nindent 4 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is meant to say indent

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this too 😄 but it in fact adds a newline along with the indent

@prydonius
Copy link
Member

@unguiculus looks like the e2e test is trying to install a chart inside the directory of this chart (stable/cert-manager/webhook) that shouldn't be installed. Any idea why this might be happening?

@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2019
@munnerz
Copy link
Collaborator Author

munnerz commented Jan 22, 2019

To clarify, this sub-chart should be installed, and is installed just fine as part of the main cert-manager chart. The issue is as @prydonius says, the e2e script also attempts to install the 'webhook' chart on its own (seemingly because it treats the sub-chart as an independent chart)

I guess this is down to the way the chart-testing code discovers charts that need testing?

@davidkarlsen
Copy link
Member

@munnerz have a look at the failing test?

@munnerz
Copy link
Collaborator Author

munnerz commented Jan 23, 2019 via email

@munnerz munnerz force-pushed the automated-sync-release-0.6-master branch from d4ba826 to 7b96b5b Compare January 23, 2019 09:33
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2019
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2019
@unguiculus unguiculus mentioned this pull request Jan 23, 2019
Merged
@munnerz munnerz force-pushed the automated-sync-release-0.6-master branch from 4d3213a to 7b96b5b Compare January 23, 2019 13:45
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2019
@ivanayov ivanayov mentioned this pull request Jan 23, 2019
Closed
unguiculus added a commit to helm/chart-testing that referenced this pull request Jan 23, 2019
@unguiculus
Require charts to be in direct subdirectories of configured charts di…
3742279 
…rs (#90)

Fixes a regression introduced in #73 so that chart directories were no longer required to be in a direct subdirectory of configured chart directories.

This caused problems in helm/charts#10830.

cc @munnerz
@munnerz
Copy link
Collaborator Author

munnerz commented Jan 23, 2019

/retest

3 similar comments
@munnerz
Copy link
Collaborator Author

munnerz commented Jan 23, 2019

/retest

@munnerz
Copy link
Collaborator Author

munnerz commented Jan 23, 2019

/retest

@munnerz
Copy link
Collaborator Author

munnerz commented Jan 23, 2019

/retest

@simonswine
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 10ddb0c into helm:master Jan 23, 2019
@munnerz munnerz mentioned this pull request Jan 23, 2019
Closed
victorboissiere pushed a commit to victorboissiere/charts that referenced this pull request Jan 24, 2019
@munnerz
cert-manager: fast-forward to upstream 9a8f4371 (helm#10830)
39615f4 
* Bump version strings for v0.6.0 (cert-manager/cert-manager#1247)
* Set CA sync backoff limit & add verifying installation docs (cert-manager/cert-manager#1245)
* Added securityContext to cert-manager deployment pods in helm chart (cert-manager/cert-manager#1237)
* Move Helm chart to deploy/charts/cert-manager (cert-manager/cert-manager#1235)
* chart: allow deployment strategy customization
* webhook: remove hardcoded image (cert-manager/cert-manager#1039)
* Remove crd-install annotation from Challenges and Orders
* Add Challenge and Order CRDs
* Add certificates and issuers to aggregated RBAC for view, edit and admin ClusterRoles. (cert-manager/cert-manager#872)
* Use fixed image tag for ca-helper and add description

Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: Victor Boissiere <victor.boissiere@neo9.fr>
@bootc bootc mentioned this pull request Feb 7, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swade1987 swade1987 swade1987 left review comments

@kragniz kragniz Awaiting requested review from kragniz

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@munnerz @prydonius @davidkarlsen @simonswine @k8s-ci-robot @swade1987 @helm-bot