Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/efs-provisioner] Fix annotations #11964

Merged
merged 3 commits into from Mar 19, 2019
Merged

[stable/efs-provisioner] Fix annotations #11964

merged 3 commits into from Mar 19, 2019

Conversation

jacobtomlinson
Copy link
Contributor

@jacobtomlinson jacobtomlinson commented Mar 6, 2019 •
edited

It looks like annotations were added in #10829 but there is a bug which has been highlighted since that PR was merged.

This PR fixes those issues raised and also adds the annotations to the default values file as well as the README.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2019
@k8s-ci-robot k8s-ci-robot requested a review from foxish March 6, 2019 17:00
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jacobtomlinson. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2019
[stable/efs-provisioner] Fix annotations
c2f2642 
Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2019
@jacobtomlinson
Copy link
Contributor Author

/assign @cpanato

Fix annotations
c6a9d78 
Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2019
@jacobtomlinson
Copy link
Contributor Author

Could someone place have another look at this?

@hareku
Copy link
Collaborator

hareku commented Mar 18, 2019 •
edited

@jacobtomlinson Thank you for your PR.
Would you bump a Chart version?

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2019
@jacobtomlinson
Copy link
Contributor Author

@hareku done!

@hareku
Copy link
Collaborator

hareku commented Mar 19, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hareku, jacobtomlinson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2019
@k8s-ci-robot
Copy link
Contributor

@hareku: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 540fa83 into helm:master Mar 19, 2019
@jacobtomlinson jacobtomlinson deleted the efs-annotations branch March 19, 2019 09:24
rmccorm4 pushed a commit to rmccorm4/charts that referenced this pull request Mar 26, 2019
@jacobtomlinson @rmccorm4
[stable/efs-provisioner] Fix annotations (helm#11964)
264089d 
* [stable/efs-provisioner] Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

* Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>
crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019
@jacobtomlinson
[stable/efs-provisioner] Fix annotations (helm#11964)
75a3bbe 
* [stable/efs-provisioner] Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

* Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>
crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019
@jacobtomlinson
[stable/efs-provisioner] Fix annotations (helm#11964)
4a84c73 
* [stable/efs-provisioner] Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

* Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>
Signed-off-by: Kevin Duane <duank001@apps.disney.com>
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
@jacobtomlinson @devnulled
[stable/efs-provisioner] Fix annotations (helm#11964)
36a115a 
* [stable/efs-provisioner] Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

* Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpanato cpanato cpanato requested changes

@davidkarlsen davidkarlsen Awaiting requested review from davidkarlsen

@foxish foxish Awaiting requested review from foxish

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jacobtomlinson @k8s-ci-robot @hareku @cpanato @helm-bot