Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/efs-provisioner] Fix annotations #11964

Merged
merged 3 commits into from Mar 19, 2019

Conversation

Projects
None yet
5 participants
@jacobtomlinson
Copy link
Contributor

commented Mar 6, 2019

It looks like annotations were added in #10829 but there is a bug which has been highlighted since that PR was merged.

This PR fixes those issues raised and also adds the annotations to the default values file as well as the README.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@k8s-ci-robot k8s-ci-robot requested a review from davidkarlsen Mar 6, 2019

@helm-bot helm-bot added the size/XS label Mar 6, 2019

@k8s-ci-robot k8s-ci-robot requested a review from foxish Mar 6, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

Hi @jacobtomlinson. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jacobtomlinson jacobtomlinson force-pushed the jacobtomlinson:efs-annotations branch from a682462 to 2714ef4 Mar 6, 2019

[stable/efs-provisioner] Fix annotations
Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

@jacobtomlinson jacobtomlinson force-pushed the jacobtomlinson:efs-annotations branch from 2714ef4 to c2f2642 Mar 6, 2019

@helm-bot helm-bot added size/XS and removed size/XS labels Mar 6, 2019

@jacobtomlinson

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

/assign @cpanato

Fix annotations
Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

@helm-bot helm-bot added size/S and removed size/XS labels Mar 8, 2019

@jacobtomlinson

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

Could someone place have another look at this?

@hareku

This comment has been minimized.

Copy link
Collaborator

commented Mar 18, 2019

@jacobtomlinson Thank you for your PR.
Would you bump a Chart version?

@helm-bot helm-bot added size/S and removed size/S labels Mar 19, 2019

@jacobtomlinson

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

@hareku done!

@hareku

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 19, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hareku, jacobtomlinson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

@hareku: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 540fa83 into helm:master Mar 19, 2019

6 checks passed

DCO DCO
Details
ci/circleci: lint-charts Your tests passed on CircleCI!
Details
ci/circleci: lint-scripts Your tests passed on CircleCI!
Details
dco-labeler All commits have signoff
pull-charts-e2e Job succeeded.
Details
tide In merge pool.
Details

@jacobtomlinson jacobtomlinson deleted the jacobtomlinson:efs-annotations branch Mar 19, 2019

rmccorm4 added a commit to rmccorm4/charts that referenced this pull request Mar 26, 2019

[stable/efs-provisioner] Fix annotations (helm#11964)
* [stable/efs-provisioner] Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

* Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019

[stable/efs-provisioner] Fix annotations (helm#11964)
* [stable/efs-provisioner] Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

* Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019

[stable/efs-provisioner] Fix annotations (helm#11964)
* [stable/efs-provisioner] Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

* Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>
Signed-off-by: Kevin Duane <duank001@apps.disney.com>

PierluigiLenociAkelius added a commit to PierluigiLenociAkelius/charts that referenced this pull request Apr 25, 2019

[stable/efs-provisioner] Fix annotations (helm#11964)
* [stable/efs-provisioner] Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

* Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@akelius.de>

devnulled added a commit to devnulled/charts that referenced this pull request Apr 25, 2019

[stable/efs-provisioner] Fix annotations (helm#11964)
* [stable/efs-provisioner] Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>

* Fix annotations

Signed-off-by: Jacob Tomlinson <jacob.tomlinson@informaticslab.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.