Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Allow setting an emptyDir sizeLimit for Prometheus #12281

Merged
merged 3 commits into from May 10, 2019
Merged

Allow setting an emptyDir sizeLimit for Prometheus #12281

merged 3 commits into from May 10, 2019

Conversation

mtougeron
Copy link
Contributor

Signed-off-by: Mike Tougeron tougeron@adobe.com

What this PR does / why we need it:

This PR allows you to set a sizeLimit for Prometheus' emptyDir volume when not using persistent storage.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@mtougeron
Allow setting an emptyDir sizeLimit for Prometheus
07c97b2 
Signed-off-by: Mike Tougeron <tougeron@adobe.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mtougeron. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 15, 2019
@mtougeron
Copy link
Contributor Author

@mgoodness / @gianrubio just wanted to ping you for a rough idea of when you'll be able to review this. Thanks!

gianrubio
gianrubio approved these changes Apr 1, 2019
View reviewed changes
Copy link
Collaborator

@gianrubio gianrubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. ok-to-test approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2019
@mtougeron
Copy link
Contributor Author

I'll resolve the conflicts for this today

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 9, 2019
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 9, 2019
@mtougeron mtougeron force-pushed the set-prometheus-emptydir-requests branch from f86c04e to fc08c26 Compare May 9, 2019 18:44
@mtougeron
Bump the version number
09f70b9 
Signed-off-by: Mike Tougeron <tougeron@adobe.com>
@mtougeron mtougeron force-pushed the set-prometheus-emptydir-requests branch from fc08c26 to 09f70b9 Compare May 9, 2019 18:48
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 9, 2019
gianrubio
gianrubio approved these changes May 10, 2019
View reviewed changes
Copy link
Collaborator

@gianrubio gianrubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianrubio, mtougeron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d844948 into helm:master May 10, 2019
@mtougeron mtougeron deleted the set-prometheus-emptydir-requests branch May 10, 2019 17:32
stackedsax added a commit to stackedsax/charts that referenced this pull request May 12, 2019
@stackedsax
Merge remote-tracking branch 'upstream/master' into storm_chart
57d7eab 
* upstream/master: (4160 commits)
  [stable/mysql] support loadBalancerIP, configurationFilesPath (helm#13670)
  Allow setting an emptyDir sizeLimit for Prometheus (helm#12281)
  [stable/concourse] Add possibility to set strategy for rollingUpdates (web) (helm#13616)
  [stable/cluster-autoscaler] support dnsPolicy (helm#9029)
  [stable/rabbitmq-ha] allow setting different topology keys for anti affinity (helm#13635)
  [stable/airflow] Fix prometheusRule additionalLabels (helm#13683)
  [stable/postgresql] Set the right env. variable to enable debug (helm#13682)
  Use KUBERNETES_SERVICE_HOST environment variable (helm#13676)
  Enable new_k8s flag by default (helm#13618)
  [stable/prometheus-operator] Bump version dependency (helm#13625)
  [stable/odoo] Update Odoo dependencies (helm#13657)
  [stable/airflow] Add support for prometheus rules (helm#13662)
  [stable/signalfx-agent] Adding deprication notice (helm#13586)
  [stable/kube-state-metrics] Allows deploying ServiceAccount without RBAC (helm#13495)
  stable/ambassador - Update to Ambassador 0.61.0 (helm#13661)
  [stable/redmine] Update Redmine dependencies (helm#13658)
  [stable/chart] Add deploymentStrategy on HackMD chart (helm#13645)
  [stable/grafana] Adds imagePullSecrets to test pod (helm#13574)
  [stable/k8s-dashboard] Clean up cluster-service label (helm#13545)
  [stable/postgresql] Fix 'mountPath' for password files. (helm#13653)
  ...
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@mtougeron @goshlanguage
Allow setting an emptyDir sizeLimit for Prometheus (helm#12281)
3132a43 
* Allow setting an emptyDir sizeLimit for Prometheus

Signed-off-by: Mike Tougeron <tougeron@adobe.com>

* Bump the version number

Signed-off-by: Mike Tougeron <tougeron@adobe.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@mtougeron @eyenx
Allow setting an emptyDir sizeLimit for Prometheus (helm#12281)
47b4bd5 
* Allow setting an emptyDir sizeLimit for Prometheus

Signed-off-by: Mike Tougeron <tougeron@adobe.com>

* Bump the version number

Signed-off-by: Mike Tougeron <tougeron@adobe.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gianrubio gianrubio gianrubio approved these changes

@mgoodness mgoodness Awaiting requested review from mgoodness

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtougeron @k8s-ci-robot @gianrubio @helm-bot