[stable/openvpn]: Adds Release.Namespace

[jasongwartz]

What this PR does / why we need it:

Adds namespace configuration to the openvpn chart

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md

[k8s-ci-robot]

Hi @jasongwartz. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jasongwartz]

/lgtm

edit: oops, can't do that on my own pr

[k8s-ci-robot]

@jasongwartz: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasongwartz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/openvpn/OWNERS [jasongwartz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davidkarlsen]

Why is this needed? Helm handles this automagically when you deploy into a --namespace <some namespace>

[davidkarlsen]

/hold

[jasongwartz]

I thought that was the case, and I found it to be true in my testing as well - but I noticed many other charts have this, so I was wondering if there was an edge case where this is useful that I wasn’t considering.

Eg:

charts/stable/cert-manager/templates/deployment.yaml

Line 5 in 10ddb0c

namespace: {{ .Release.Namespace | quote }}

charts/stable/jaeger-operator/templates/role-binding.yaml

Line 6 in 83905b9

namespace: {{ .Release.Namespace }}

charts/stable/kured/templates/daemonset.yaml

Line 5 in f841959

namespace: {{ .Release.Namespace }}

charts/stable/cert-manager/webhook/templates/pki.yaml

Line 8 in 2978da5

namespace: {{ .Release.Namespace | quote }}

Are these examples redundant, or does the helm magic apply differently to different object types (eg. deployment vs rolebinding vs CRD)?

[eh-am]

this is useful when deploying using Spinnaker

spinnaker/spinnaker#2909 (comment)

also related:
helm/helm#3553

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.