This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
stackdriver-exporter: allow using a google service account #13214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
Contribution Allowed
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @Stelminator. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cpanato
reviewed
Apr 25, 2019
helm-bot
added
size/M
via service account key or existing secret Signed-off-by: Christopher A. Stelma <stelminator@gmail.com>
Stelminator
force-pushed
the
stackdriver-exporter-service-account
branch
from
d531120
to
749f3d2
Compare
helm-bot
added
the
Contribution Allowed
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
and removed
needs-ok-to-test
cpanato
approved these changes
Apr 26, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, Stelminator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
legal90
added a commit
to volvo-cars/helm-charts
that referenced
this pull request
Apr 27, 2019
* spinnaker-additional-configmaps: (158 commits) [stable/spinnaker] Bump chart version [stable/spinnaker] Allow to use existing additionalConfigMaps objects [stable/instana-agent] Add instana-agent chart to stable (helm#12799) [stable/spring-cloud-data-flow] apiGroup extension does not have permissions over Jobs (helm#12174) Fluentd - Add option to add environment variables from secrets (helm#12565) Fluentd - Allow ingress path to be configurable (helm#12561) [stable/openebs]: update NDM image tag to 0.3.5 (helm#13282) stable/phabricator: update to 2019.16.0 (helm#13307) [stable/jenkins] Add support for idleMinutes and serviceAccount (helm#13263) [stable/gocd] Bump up k8 elastic agent to latest and bump up GoCD to v19.3.0 (helm#13301) [stable/atlantis] Add `--default-tf-version=` and `--allow-fork-prs` flag (helm#13299) stackdriver-exporter: allow google service account (helm#13214) SC-4435 Do not start the container if particular token is not provided (helm#13304) [stable/spring-cloud-data-flow] Update to new SCDF version 2.0.2 (helm#12951) allow to set COCKROACH_ENGINE_MAX_SYNC_DURATION (helm#13244) Use same JENKINS_URL no matter if slaves use different namespace (helm#12564) stable/concourse: separate worker, web deployments (helm#12920) [ci] Upgrade to chart-testing v2.3.3 (helm#13294) fixes incompatibility with 1.11 (helm#13261) Detect current network and netmask (helm#13250) ... # Conflicts: # stable/spinnaker/Chart.yaml
dpkirchner
pushed a commit
to dpkirchner/charts
that referenced
this pull request
May 9, 2019
via service account key or existing secret Signed-off-by: Christopher A. Stelma <stelminator@gmail.com>
goshlanguage
pushed a commit
to goshlanguage/charts
that referenced
this pull request
May 17, 2019
via service account key or existing secret Signed-off-by: Christopher A. Stelma <stelminator@gmail.com>
eyenx
pushed a commit
to eyenx/charts
that referenced
this pull request
May 28, 2019
via service account key or existing secret Signed-off-by: Christopher A. Stelma <stelminator@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enables the use of a google service account from a key or existing secret.
My use case is to monitor a project other than the one in which the chart is hosted and/or from outside gke.
@apenney
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]