[stable/mysql] add namespace metadata #13924
Conversation
this is needed for when helm is used purely as a templating tool, since helm template does not add the namespace helm/helm#3553 Signed-off-by: eduardo aleixo <eduardoaleixomartins@gmail.com>
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @eh-am. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eh-am, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -3,6 +3,7 @@ apiVersion: v1 | |||
| kind: ConfigMap | |||
| metadata: | |||
| name: {{ template "mysql.fullname" . }}-configuration | |||
| namespace: {{ .Release.Namespace }} | |||
There was a problem hiding this comment.
doesnt helm do this already?
There was a problem hiding this comment.
only at deployment time, so if you are using helm purely as a template tool (for instance in Spinnaker) it doesn't do that.
|
ah. ok. |
this is needed for when helm is used purely as a templating tool, since helm template does not add the namespace helm/helm#3553 Signed-off-by: eduardo aleixo <eduardoaleixomartins@gmail.com>
this is needed for when helm is used purely as a templating tool, since helm template does not add the namespace helm/helm#3553 Signed-off-by: eduardo aleixo <eduardoaleixomartins@gmail.com>
Signed-off-by: eduardo aleixo eduardoaleixomartins@gmail.com
What this PR does / why we need it:
this is needed for when helm is used purely as a templating tool,
since helm template does not add the namespace
helm/helm#3553
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]