Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/falco] Fix issues from https://github.com/helm/charts/pull/14813 #15130

Closed
wants to merge 1 commit into from
Closed

[stable/falco] Fix issues from https://github.com/helm/charts/pull/14813 #15130

wants to merge 1 commit into from

Conversation

nestorsalceda
Copy link
Collaborator

Signed-off-by: Néstor Salceda nestor.salceda@sysdig.com

What this PR does / why we need it:

This PR fixes the issues with previous pull request #14813

There were 3 things that were not properly reviewed:

  • Why was update to 0.8.x series without a valid reason?
  • Didn't have a ChangeLog entry
  • The PR name doesn't start by [stable/falco]

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

Signed-off-by: Néstor Salceda <nestor.salceda@sysdig.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nestorsalceda
To complete the pull request process, please assign bencer
You can assign the PR to them by writing /assign @bencer in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nestorsalceda
Copy link
Collaborator Author

/assign @bencer

@k8s-ci-robot
Copy link
Contributor

@nestorsalceda: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e 6684e5a link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stale
Copy link

stale bot commented Jul 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2019
@stale
Copy link

stale bot commented Aug 11, 2019

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants