Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/falco] Add more role resources to ClusterRole #16396

Merged
merged 4 commits into from
Aug 21, 2019
Merged

[stable/falco] Add more role resources to ClusterRole #16396

merged 4 commits into from
Aug 21, 2019

Conversation

rytswd
Copy link
Contributor

@rytswd rytswd commented Aug 19, 2019

What this PR does / why we need it:

Added 3 resources

  • daemonsets
  • deployments
  • replicasets

Without these in place, Falco spits out so many errors of "PERMISSION_DENIED"

Special notes for your reviewer:

These were added in the falco integration example (https://github.com/falcosecurity/falco/blob/bd4c3ffa39da02e8ce1b6a96ab871d254d663fdf/integrations/k8s-using-daemonset/k8s-with-rbac/falco-account.yaml)
It seems there was a drift here, and thus simply added the missing 3 above

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @rytswd. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 19, 2019
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 19, 2019
@rytswd
Copy link
Contributor Author

rytswd commented Aug 19, 2019

/assign @bencer

@bencer
Copy link
Collaborator

bencer commented Aug 19, 2019

Can you add a changelog entry? Otherwise looks good.

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Aug 20, 2019
@rytswd
Copy link
Contributor Author

rytswd commented Aug 20, 2019

Sorry about missing the doc! I have added a line for v1.0.5 in the CHANGELOG.md. I also added a referenc to the original PR falcosecurity/falco#514 there.

@bencer
Copy link
Collaborator

bencer commented Aug 20, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 20, 2019
@rytswd
Add more role resources to ClusterRole
5b8ad25 
Added 3 resources
- daemonsets
- deployments
- replicasets

These were added in the falco integration example (https://github.com/falcosecurity/falco/blob/bd4c3ffa39da02e8ce1b6a96ab871d254d663fdf/integrations/k8s-using-daemonset/k8s-with-rbac/falco-account.yaml)

Signed-off-by: Ryota <rytswd@gmail.com>
@rytswd
Bump the version from 1.0.4 to 1.0.5
ead20a9 
Signed-off-by: Ryota <rytswd@gmail.com>
@rytswd
Add entry for v1.0.5
6b40e44 
Signed-off-by: Ryota <rytswd@gmail.com>
@rytswd
Update CHANGELOG.md
b3c6de3 
Signed-off-by: Ryota <rytswd@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2019
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 20, 2019
@rytswd
Copy link
Contributor Author

rytswd commented Aug 20, 2019

Sorry, I missed the DCO check as I updated from GitHub UI - rebased and sorted it out.

@bencer
Copy link
Collaborator

bencer commented Aug 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bencer, rytswd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 149fd16 into helm:master Aug 21, 2019
@rytswd rytswd deleted the patch-1 branch August 22, 2019 18:05
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
@rytswd @kengou
[stable/falco] Add more role resources to ClusterRole (helm#16396)
fe3aebe 
* Add more role resources to ClusterRole

Added 3 resources
- daemonsets
- deployments
- replicasets

These were added in the falco integration example (https://github.com/falcosecurity/falco/blob/bd4c3ffa39da02e8ce1b6a96ab871d254d663fdf/integrations/k8s-using-daemonset/k8s-with-rbac/falco-account.yaml)

Signed-off-by: Ryota <rytswd@gmail.com>

* Bump the version from 1.0.4 to 1.0.5

Signed-off-by: Ryota <rytswd@gmail.com>

* Add entry for v1.0.5

Signed-off-by: Ryota <rytswd@gmail.com>

* Update CHANGELOG.md

Signed-off-by: Ryota <rytswd@gmail.com>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
@rytswd
[stable/falco] Add more role resources to ClusterRole (helm#16396)
036ccf2 
* Add more role resources to ClusterRole

Added 3 resources
- daemonsets
- deployments
- replicasets

These were added in the falco integration example (https://github.com/falcosecurity/falco/blob/bd4c3ffa39da02e8ce1b6a96ab871d254d663fdf/integrations/k8s-using-daemonset/k8s-with-rbac/falco-account.yaml)

Signed-off-by: Ryota <rytswd@gmail.com>

* Bump the version from 1.0.4 to 1.0.5

Signed-off-by: Ryota <rytswd@gmail.com>

* Add entry for v1.0.5

Signed-off-by: Ryota <rytswd@gmail.com>

* Update CHANGELOG.md

Signed-off-by: Ryota <rytswd@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bencer bencer Awaiting requested review from bencer

@nestorsalceda nestorsalceda Awaiting requested review from nestorsalceda

Assignees

@bencer bencer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rytswd @k8s-ci-robot @bencer @helm-bot