Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] Update README.md for wrong example prometheus.prometheusSpec.retentionSize #17725

Merged
merged 5 commits into from Oct 12, 2019
Merged

[stable/prometheus-operator] Update README.md for wrong example prometheus.prometheusSpec.retentionSize #17725

merged 5 commits into from Oct 12, 2019

Conversation

Eji4h
Copy link
Contributor

@Eji4h Eji4h commented Oct 6, 2019 •
edited

Fix wrong example value of prometheus.prometheusSpec.retentionSize to correct.

Signed-off-by: Yosapol Jitrak yosapoljittarak@hotmail.com

What this PR does / why we need it:
README in example is wrong units of retentionSize. It can't be start prometheus-prometheus-operator-prometheus workload.
image

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 6, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Eji4h. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 6, 2019
@Eji4h
Update README.md
7bf36f4 
Fix wrong example value of  `prometheus.prometheusSpec.retentionSize` to correct.

Signed-off-by: Yosapol Jitrak <yosapoljittarak@hotmail.com>
@Eji4h
Copy link
Contributor Author

Eji4h commented Oct 6, 2019

/retest

@k8s-ci-robot
Copy link
Contributor

@Eji4h: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Eji4h
Copy link
Contributor Author

Eji4h commented Oct 6, 2019

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@Eji4h: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vsliouniaev
Copy link
Collaborator

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2019
@vsliouniaev
Copy link
Collaborator

You'll need to bump the chart version for any change to be valid

@Eji4h
Copy link
Contributor Author

Eji4h commented Oct 8, 2019

You'll need to bump the chart version for any change to be valid

I update document to correct and don't change anything. Why I need to bump the chart version?

@vsliouniaev
Copy link
Collaborator

The readme is packed into the chart when it is built. If you do not change the version, a new chart version cannot be built and pushed to the chart repository.

You must bump the chart version according to semver rules (For this change, changing the minor version is ok) whenever you make any change to any file. This is enforced by the CI process and I will not be able to merge the changes until you do it.

@Eji4h
Merge remote-tracking branch 'upstream/master'
0919b06
@Eji4h
bump version
de30f3d 
Signed-off-by: Yosapol Jitrak <yosapoljittarak@hotmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2019
@Eji4h
Copy link
Contributor Author

Eji4h commented Oct 10, 2019

/retest

@Eji4h
Copy link
Contributor Author

Eji4h commented Oct 10, 2019

/ok-to-test

@vsliouniaev
Copy link
Collaborator

/retest

vsliouniaev
vsliouniaev suggested changes Oct 11, 2019
View reviewed changes
stable/prometheus-operator/Chart.yaml Outdated
@@ -10,7 +10,7 @@ name: prometheus-operator
sources:
- https://github.com/coreos/prometheus-operator
- https://coreos.com/operators/prometheus
version: 6.16.0
version: 6.17.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a bugfix, only the patch version should be changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Sorry for mistake.

@Eji4h
Bump chart version to 6.17.2
bf06fca 
Signed-off-by: Yosapol Jitrak <yosapoljittarak@hotmail.com>
@Eji4h
Copy link
Contributor Author

Eji4h commented Oct 12, 2019

/ok-to-test

@vsliouniaev
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Eji4h, vsliouniaev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a885ed8 into helm:master Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vsliouniaev vsliouniaev vsliouniaev requested changes

@gianrubio gianrubio Awaiting requested review from gianrubio

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Eji4h @k8s-ci-robot @vsliouniaev @helm-bot