Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Update deployment.yaml #18376

Merged
merged 2 commits into from Oct 28, 2019
Merged

Update deployment.yaml #18376

merged 2 commits into from Oct 28, 2019

Conversation

XHPJ
Copy link
Contributor

@XHPJ XHPJ commented Oct 26, 2019 •
edited

For newer releases this will be supported/needed. K8 v.1.15.* can already handle the versionApi: "apps/v1".

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @XHPJ. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zanhsieh
Copy link
Collaborator

@XHPJ
Could you sign DCO and bump the chart version to latest please?

@XHPJ
Update deployment.yaml
830a801 
For newer releases this will be supported/needed. K8 v.1.15.* can already handle the versionApi: "apps/v1".

Signed-off-by: XHPJ <xheladinpopaj@hotmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Oct 27, 2019
@XHPJ
Update Chart version
28af882 
Signed-off-by: XHPJ <xheladinpopaj@hotmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 27, 2019
@davidkarlsen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2019
@davidkarlsen
Copy link
Member

/assign

@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, XHPJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 454805e into helm:master Oct 28, 2019
demisx added a commit to beocommedia/charts that referenced this pull request Oct 28, 2019
@demisx
Merge remote-tracking branch 'upstream/master'
1909363 
* upstream/master: (134 commits)
  [stable/external-dns] Enable RBAC resources by default (helm#18398)
  [incubator/sparkoperator] introduce imagePullSecret at sparkoperator deployments (helm#18162)
  [stable/prometheus-operator] Remove CRD hooks from CI entirely (helm#18271)
  [stable/mcrouter] upgrade requirements (helm#18313)
  [stable/fluent-bit] Upgrade fluentbit to 1.3.2 (helm#18328)
  Update deployment.yaml (helm#18376)
  [stable/sysdig] Fix 1.16 compatibility errors introduced in v1.4.19 (helm#18230)
  [stable/bookstack] Fix mariadb values in README (helm#18385)
  [stable/memcached] - Add servicemonitor for Prometheus-operator (helm#18386)
  [stable/prometheus-cloudwatch-exporter] Update cloudwatch-exporter version. (helm#18003)
  [stable/prometheus-cloudwatch-exporter] Add myself to owners/maintainers. (helm#18093)
  [incubator/vault] Api version backwards compatibility (helm#18378)
  [stable/memcached] upgrade metrics exporter, fix PDB (helm#18387)
  [stable/home-assistant] Fix wildcard home-assistant ingress (helm#18384)
  [stable/karma] Upgrade to 0.48 (helm#17715)
  [stable/joomla] Release 6.1.11 updating components versions (helm#18364)
  [stable/prometheus-node-exporter] update NOTES.txt to show correct port (helm#17931)
  [stable/apm-server] Use a non-root user (helm#18366)
  [stable/airflow] Fix template directive value of nodePort for web service (helm#18059)
  [stable/spinnaker] Support serviceConfigs for local offline installation. (helm#18365)
  ...
demisx added a commit to beocommedia/charts that referenced this pull request Oct 28, 2019
@demisx
Merge branch 'master' into update-chart-version
e61a6cc 
* master: (135 commits)
  [stable/external-dns] Enable RBAC resources by default (helm#18398)
  [incubator/sparkoperator] introduce imagePullSecret at sparkoperator deployments (helm#18162)
  [stable/prometheus-operator] Remove CRD hooks from CI entirely (helm#18271)
  [stable/mcrouter] upgrade requirements (helm#18313)
  [stable/fluent-bit] Upgrade fluentbit to 1.3.2 (helm#18328)
  Update deployment.yaml (helm#18376)
  [stable/sysdig] Fix 1.16 compatibility errors introduced in v1.4.19 (helm#18230)
  [stable/bookstack] Fix mariadb values in README (helm#18385)
  [stable/memcached] - Add servicemonitor for Prometheus-operator (helm#18386)
  [stable/prometheus-cloudwatch-exporter] Update cloudwatch-exporter version. (helm#18003)
  [stable/prometheus-cloudwatch-exporter] Add myself to owners/maintainers. (helm#18093)
  [incubator/vault] Api version backwards compatibility (helm#18378)
  [stable/memcached] upgrade metrics exporter, fix PDB (helm#18387)
  [stable/home-assistant] Fix wildcard home-assistant ingress (helm#18384)
  [stable/karma] Upgrade to 0.48 (helm#17715)
  [stable/joomla] Release 6.1.11 updating components versions (helm#18364)
  [stable/prometheus-node-exporter] update NOTES.txt to show correct port (helm#17931)
  [stable/apm-server] Use a non-root user (helm#18366)
  [stable/airflow] Fix template directive value of nodePort for web service (helm#18059)
  [stable/spinnaker] Support serviceConfigs for local offline installation. (helm#18365)
  ...
anandsinghkunwar pushed a commit to anandsinghkunwar/charts that referenced this pull request Oct 30, 2019
@XHPJ @anandsinghkunwar
Update deployment.yaml (helm#18376)
fbb77e3 
* Update deployment.yaml

For newer releases this will be supported/needed. K8 v.1.15.* can already handle the versionApi: "apps/v1".

Signed-off-by: XHPJ <xheladinpopaj@hotmail.com>

* Update Chart version

Signed-off-by: XHPJ <xheladinpopaj@hotmail.com>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@XHPJ
Update deployment.yaml (helm#18376)
21e147d 
* Update deployment.yaml

For newer releases this will be supported/needed. K8 v.1.15.* can already handle the versionApi: "apps/v1".

Signed-off-by: XHPJ <xheladinpopaj@hotmail.com>

* Update Chart version

Signed-off-by: XHPJ <xheladinpopaj@hotmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jlegrone jlegrone Awaiting requested review from jlegrone

@prydonius prydonius Awaiting requested review from prydonius

Assignees

@davidkarlsen davidkarlsen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@XHPJ @k8s-ci-robot @zanhsieh @davidkarlsen @helm-bot