Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/skywalking]add SkyWalking chart #18758

Closed
wants to merge 4 commits into from

Conversation

innerpeacez
Copy link

@innerpeacez innerpeacez commented Nov 11, 2019

Signed-off-by: innerpeacez innerpeace.zhai@gmail.com

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Apache SkyWalking
Application performance monitor tool for distributed systems, especially designed for microservices, cloud native and container-based (Docker, K8s, Mesos) architectures.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: innerpeacez <innerpeace.zhai@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 11, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 11, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @innerpeacez. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 11, 2019
@innerpeacez
Copy link
Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: innerpeacez
To complete the pull request process, please assign scottrigby
You can assign the PR to them by writing /assign @scottrigby in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: innerpeacez <innerpeace.zhai@gmail.com>
@innerpeacez innerpeacez changed the title add SkyWalking chart [incubator/skywalking]add SkyWalking chart Nov 11, 2019
Signed-off-by: innerpeacez <innerpeace.zhai@gmail.com>
@zanhsieh
Copy link
Collaborator

zanhsieh commented Nov 11, 2019

@innerpeacez
Just would like to let you know that currently new charts are encouraged to host their own. As per discussion with @maorfr :
#5071 (comment)

@innerpeacez
Copy link
Author

@innerpeacez
Just would like to let you know that currently new charts are encouraged to host their own. As per discussion with @maorfr :
#5071 (comment)

Thanks for letting me know, is this repo still receiving new charts?

@scottrigby
Copy link
Member

Hi 👋 new charts are no longer accepted to stable or incubator. See Status of the Project and Deprecation Timeline for more info about that.

Good news is you can host a Helm chart yourself on GitHub, use the same tools as this repo does for automatic Chart testing and releasing, and list your Helm repo on https://helm.hub.sh. Follow this issue for info about existing guidelines and upcoming improvements: https://github.com/helm/charts/issues/7800

@scottrigby scottrigby closed this Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants