Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/gitlab-ce,ee] Add deprecation note in favor of official Charts #1876

Merged
merged 15 commits into from Oct 14, 2017

Conversation

lambertjosh
Copy link
Contributor

@lambertjosh lambertjosh commented Aug 29, 2017

GitLab provides a set of official charts. These charts are actively being developed, and are planned to be added to this repo soon. In the interim, we should inform users that they may want to consider those charts to get started.

Fixes #1138

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 29, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @lambertjosh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2017
@lambertjosh
Copy link
Contributor Author

Signed the CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 29, 2017
@prydonius
Copy link
Member

@lambertjosh can we add deprecated: true to the Chart.yaml files? See https://docs.helm.sh/developing_charts/#deprecating-charts

@prydonius prydonius self-assigned this Sep 5, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2017
@lambertjosh
Copy link
Contributor Author

Thanks @prydonius, I've added the deprecated: true flag as well as updated the NOTES.txt to include a warning as well.

@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2017
@unguiculus unguiculus merged commit 45cbad1 into helm:master Oct 14, 2017
dnelson pushed a commit to Vungle/charts that referenced this pull request Oct 26, 2017
helm#1876)

* Deprecate chart in favor of official chart

* Deprecate chart in favor of official GitLab chart.

* Mark chart as deprecated

* Add NOTES.txt to indicate chart is deprecated.

* Mark chart as deprecated

* Add NOTES.txt to indicate chart is deprecated

* Delete NOTES.txt

* Update NOTES.txt

* Delete NOTES.txt

* Update NOTES.txt

* Update NOTES.txt

* Update NOTES.txt

* Update NOTES.txt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants