Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/rabbitmq-ha] added checksum/secret #18792

Merged
merged 1 commit into from Nov 18, 2019

Conversation

zerkms
Copy link
Contributor

@zerkms zerkms commented Nov 11, 2019

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

It adds a checksum for the secret so that the pods had chance to be redeployed if a secret changes

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 11, 2019
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 11, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @zerkms. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 11, 2019
@zerkms zerkms force-pushed the stable/rabbitmq-ha/checksum-secret branch from a280867 to d8f564a Compare November 11, 2019 23:47
@zerkms
Copy link
Contributor Author

zerkms commented Nov 12, 2019

/assign @steven-sheehy

Copy link
Collaborator

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2019
@zerkms zerkms force-pushed the stable/rabbitmq-ha/checksum-secret branch from d8f564a to 2b38162 Compare November 12, 2019 20:45
Signed-off-by: Ivan Kurnosov <zerkms@zerkms.ru>
@zerkms zerkms force-pushed the stable/rabbitmq-ha/checksum-secret branch from b5b9bc1 to 104f1db Compare November 17, 2019 20:58
Copy link
Collaborator

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steven-sheehy, zerkms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 16f372d into helm:master Nov 18, 2019
@zerkms zerkms deleted the stable/rabbitmq-ha/checksum-secret branch November 18, 2019 19:26
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
Signed-off-by: Ivan Kurnosov <zerkms@zerkms.ru>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
Signed-off-by: Ivan Kurnosov <zerkms@zerkms.ru>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
Signed-off-by: Ivan Kurnosov <zerkms@zerkms.ru>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add checksum for secrets file in rabbitmq-ha
4 participants