Make liveness and readiness probes configurable

[mrtndwrd]

What this PR does / why we need it:

Closes #19623

Which issue this PR fixes

• fixes # [stable/rocketchat] Liveness and Readiness probes should be configurable #19623

Special notes for your reviewer:

Tagging the maintainers so this can be merged quickly

@geekgonecrazy @pierreozoux @verwilst @srueg

Checklist

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/mychartname])

[k8s-ci-robot]

Hi @mrtndwrd. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[srueg]

/ok-to-test

[mrtndwrd]

Thanks for the suggestions! I amended the previous commit with the right README values

[mrtndwrd]

pull-charts-e2e failed. What does this test do? Is it related to my changes?

[srueg]

/test pull-charts-e2e

[davidkarlsen]

/retest

[mrtndwrd]

@srueg it seems like these test failures are not related to the rocketchat chart? If I understand the logs correctly it starts the pods correctly, everything's fine, then something weird happens..? I don't think I have access to the test source, so I can't really see what causes this python error:

...
 I1217 14:38:09.624] ========================================================================================================================
I1217 14:38:09.624] Deleting release 'rocketchat-q4ipib8tcc'...
I1217 14:38:10.680] release "rocketchat-q4ipib8tcc" deleted
I1217 14:38:10.684] Deleting namespace 'rocketchat-presubmit-19637-1206943879878676480-q4ipib8tcc'...
I1217 14:38:10.983] namespace "rocketchat-presubmit-19637-1206943879878676480-q4ipib8tcc" deleted
I1217 14:38:49.895] Namespace 'rocketchat-presubmit-19637-1206943879878676480-q4ipib8tcc' terminated.
I1217 14:38:49.896] Error linting and installing charts: Error processing charts
I1217 14:38:49.896] ------------------------------------------------------------------------------------------------------------------------
I1217 14:38:49.896]  ✖︎ rocketchat => (version: "2.0.1", path: "stable/rocketchat") > Error waiting for process: exit status 1
I1217 14:38:49.896] ------------------------------------------------------------------------------------------------------------------------
I1217 14:38:50.357] b682dc5dabd91826a24abc9849467f3bd353d0e4001e9e8db00a048e5e689d5f
W1217 14:38:50.370] Traceback (most recent call last):
W1217 14:38:50.370]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 50, in <module>
W1217 14:38:50.370]     main(ARGS.env, ARGS.cmd + ARGS.args)
W1217 14:38:50.370]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 41, in main
W1217 14:38:50.371]     check(*cmd)
W1217 14:38:50.371]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 30, in check
W1217 14:38:50.371]     subprocess.check_call(cmd)
W1217 14:38:50.371]   File "/usr/lib/python2.7/subprocess.py", line 190, in check_call
W1217 14:38:50.371]     raise CalledProcessError(retcode, cmd)
W1217 14:38:50.371] subprocess.CalledProcessError: Command '('./test/e2e.sh',)' returned non-zero exit status 1 

[mrtndwrd]

@srueg @davidkarlsen is there anything I can do to speed up this process? I need this change for my project and I don't like having to use my own fork to install the chart. If you can point me to why the test is failing I'd be happy to fix it

/retest

[verwilst]

/test pull-charts-e2e

[srueg]

I also don't know the test setup that well and can't see the obvious error. I'll take another look.

[srueg]

I opened another PR without any changes to test the CI process: #19696 which also failed.

You can find the logs here: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/helm_charts/19637/pull-charts-e2e/1207613472548851712/

It seems that the Rocke.Chat container crashes for some reason. Unfortunately the logs only show the current pod which didn't fail (or didn't log anything).

[srueg]

Maybe @unguiculus could give us a hand here?

[srueg]

/lgtm

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[pierreozoux]

Lgtm sorry for delay

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[mrtndwrd]

Hi, this MR has been approved by 1 reviewer. Some tests still fail, but that shouldn't be due to my changes. Do you want me to merge master into this branch to see if that fixes the problem? Or can it otherwise be approved by a second reviewer? Thanks!

[srueg]

Yes, let's try to merge (or rebase) master. The tests are required to succeed in order to merge it...

[mrtndwrd]

I0224 13:28:26.352] Installing chart with values file 'stable/rocketchat/ci/ci-values.yaml'...
I0224 13:28:26.352] 
I0224 13:38:28.077] Error: release rocketchat-o311slu9hb failed: timed out waiting for the condition
I0224 13:38:28.078] ========================================================================================================================
I0224 13:38:28.078] ........................................................................................................................
I0224 13:38:28.079] ==> Events of namespace rocketchat-presubmit-19637-1231933663680139264-o311slu9hb
I0224 13:38:28.079] ........................................................................................................................ 

Should I increase the timeout in values.yaml?

[srueg]

No idea why this fails. In the logs it looks like RocketChat successfully starts up...
Which timeout would you increase? You could also change this in ci/ci-values.yaml if it's specific to CI

[mrtndwrd]

/retest

Hmm, I'm not sure which timeout it runs into exactly, TBH. On slow systems, we have seen that pods get restarted because they don't react to the liveness probe in time, so we've increased the livenessProbe.initialDelaySeconds for other projects.

We can also try to retest to see if it's a consistent problem

[mrtndwrd]

/retest

[mrtndwrd]

Yay, test finally succeeded!

[srueg]

/approve

[srueg]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrtndwrd, srueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/rocketchat/OWNERS [srueg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment