Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/verdaccio] Adding verdaccio deprecation warning #21929

Merged
merged 1 commit into from Apr 20, 2020
Merged

[stable/verdaccio] Adding verdaccio deprecation warning #21929

merged 1 commit into from Apr 20, 2020

Conversation

juanpicado
Copy link
Contributor

Signed-off-by: Juan Picado @jotadeveloper juanpicado19@gmail.com

What this PR does / why we need it:

Adding deprecation warning and moved the repository to charts

This will be hosted in helm hub pending: helm/hub#307

Special notes for your reviewer:

CC: @etiennetremel

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@juanpicado
[stable/verdaccio] Adding verdaccio deprecation warning
1fad124 
Signed-off-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Add Verdaccio Chart

Signed-off-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Apr 15, 2020
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 15, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @juanpicado. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2020
@juanpicado juanpicado mentioned this pull request Apr 15, 2020
Closed
@zanhsieh
Copy link
Collaborator

/retest-not-required-docs-only

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2020
@zanhsieh
Copy link
Collaborator

/ok-to-test

@maorfr
Copy link
Member

maorfr commented Apr 20, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanpicado, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2c964c3 into helm:master Apr 20, 2020
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@juanpicado
[stable/verdaccio] Adding verdaccio deprecation warning (helm#21929)
1302932 
Signed-off-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Add Verdaccio Chart

Signed-off-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@juanpicado @includerandom
[stable/verdaccio] Adding verdaccio deprecation warning (helm#21929)
d60b080 
Signed-off-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Add Verdaccio Chart

Signed-off-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@juanpicado @li-adrienloiseau
[stable/verdaccio] Adding verdaccio deprecation warning (helm#21929)
480ce31 
Signed-off-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Add Verdaccio Chart

Signed-off-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@juanpicado
[stable/verdaccio] Adding verdaccio deprecation warning (helm#21929)
ce616d9 
Signed-off-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>

Add Verdaccio Chart

Signed-off-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lachie83 lachie83 Awaiting requested review from lachie83

@maorfr maorfr Awaiting requested review from maorfr

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juanpicado @k8s-ci-robot @zanhsieh @maorfr @helm-bot