This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/openebs] Add the opportunity to change docker registry #22372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2020 10:29
Signed-off-by: olivier beyler <olivier.beyler@orange.com>
Signed-off-by: olivier beyler <olivier.beyler@orange.com>
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @obeyler. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
added 2 commits
May 13, 2020 11:22
Signed-off-by: olivier beyler <olivier.beyler@orange.com>
Signed-off-by: olivier beyler <olivier.beyler@orange.com>
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
and removed
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kmova, obeyler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 tasks
irlevesque
pushed a commit
to quantopian/charts
that referenced
this pull request
Jul 13, 2020
…22372) * Add the opportunity to change docker registry Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Add parameter in README.md Signed-off-by: olivier beyler <olivier.beyler@orange.com> * fixup missing changement Signed-off-by: olivier beyler <olivier.beyler@orange.com> * fixup defaut value in readme Signed-off-by: olivier beyler <olivier.beyler@orange.com>
includerandom
pushed a commit
to includerandom/helm_charts
that referenced
this pull request
Jul 19, 2020
…22372) * Add the opportunity to change docker registry Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Add parameter in README.md Signed-off-by: olivier beyler <olivier.beyler@orange.com> * fixup missing changement Signed-off-by: olivier beyler <olivier.beyler@orange.com> * fixup defaut value in readme Signed-off-by: olivier beyler <olivier.beyler@orange.com>
li-adrienloiseau
pushed a commit
to li-adrienloiseau/charts
that referenced
this pull request
Jul 29, 2020
…22372) * Add the opportunity to change docker registry Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Add parameter in README.md Signed-off-by: olivier beyler <olivier.beyler@orange.com> * fixup missing changement Signed-off-by: olivier beyler <olivier.beyler@orange.com> * fixup defaut value in readme Signed-off-by: olivier beyler <olivier.beyler@orange.com> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh
pushed a commit
to mmingorance-dh/charts
that referenced
this pull request
Aug 28, 2020
…22372) * Add the opportunity to change docker registry Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Add parameter in README.md Signed-off-by: olivier beyler <olivier.beyler@orange.com> * fixup missing changement Signed-off-by: olivier beyler <olivier.beyler@orange.com> * fixup defaut value in readme Signed-off-by: olivier beyler <olivier.beyler@orange.com> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: olivier beyler olivier.beyler@orange.com
Is this a new chart
no
What this PR does / why we need it:
In case of airgap, it's frequent to use a private docker registry and not neither docker.io or quay.io
It give the opportunity to change the docker repository from quai.io to private repository in one shot
and evict to have to change all docker image in the helm chart
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])