Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus] Fix incorrect rendering of enableServiceLinks #22391

Merged
merged 1 commit into from
May 14, 2020
Merged

[stable/prometheus] Fix incorrect rendering of enableServiceLinks #22391

merged 1 commit into from
May 14, 2020

Conversation

lawliet89
Copy link
Contributor

@lawliet89 lawliet89 commented May 14, 2020 •
edited

If .Values.enableServiceLinks was set to false, true was still rendered.

cf. helm/helm#3308

Signed-off-by: Yong Wen Chua lawliet89@users.noreply.github.com

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@lawliet89
[stable/prometheus] Fix incorrect rendering of enableServiceLinks
09195e1 
cf. helm/helm#3308

Signed-off-by: Yong Wen Chua <lawliet89@users.noreply.github.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @lawliet89. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 14, 2020
@zanhsieh
Copy link
Collaborator

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2020
@zanhsieh
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lawliet89, zanhsieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0dfb119 into helm:master May 14, 2020
iwilltry42 pushed a commit to iwilltry42/charts that referenced this pull request May 19, 2020
@lawliet89 @iwilltry42
[stable/prometheus] Fix incorrect rendering of enableServiceLinks (he…
18975ec 
…lm#22391)

cf. helm/helm#3308

Signed-off-by: Yong Wen Chua <lawliet89@users.noreply.github.com>
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@lawliet89
[stable/prometheus] Fix incorrect rendering of enableServiceLinks (he…
26d0b0e 
…lm#22391)

cf. helm/helm#3308

Signed-off-by: Yong Wen Chua <lawliet89@users.noreply.github.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@lawliet89 @includerandom
[stable/prometheus] Fix incorrect rendering of enableServiceLinks (he…
0f278de 
…lm#22391)

cf. helm/helm#3308

Signed-off-by: Yong Wen Chua <lawliet89@users.noreply.github.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@lawliet89 @li-adrienloiseau
[stable/prometheus] Fix incorrect rendering of enableServiceLinks (he…
1d72eaa 
…lm#22391)

cf. helm/helm#3308

Signed-off-by: Yong Wen Chua <lawliet89@users.noreply.github.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@lawliet89
[stable/prometheus] Fix incorrect rendering of enableServiceLinks (he…
819a778 
…lm#22391)

cf. helm/helm#3308

Signed-off-by: Yong Wen Chua <lawliet89@users.noreply.github.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanhsieh zanhsieh zanhsieh approved these changes

@gianrubio gianrubio Awaiting requested review from gianrubio

Assignees

@zanhsieh zanhsieh

@gianrubio gianrubio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lawliet89 @k8s-ci-robot @zanhsieh @gianrubio @helm-bot