Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/zookeeper] Add SSL support #23472

Closed
wants to merge 1 commit into from
Closed

Conversation

jeblair
Copy link

@jeblair jeblair commented Aug 6, 2020

This adds both quorum and client SSL support. It accepts certificate
material in kubernetes.io/tls format (i.e., compatible with cert-
manager). Client or server support can be configured separately,
and if client SSL support is enabled, plain-text client connections
are disabled.

Signed-off-by: James E. Blair jeblair@redhat.com

Is this a new chart

No

What this PR does / why we need it:

Adds SSL support.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

This adds both quorum and client SSL support.  It accepts certificate
material in kubernetes.io/tls format (i.e., compatible with cert-
manager).  Client or server support can be configured separately,
and if client SSL support is enabled, plain-text client connections
are disabled.

Signed-off-by: James E. Blair <jeblair@redhat.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @jeblair. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jeblair
To complete the pull request process, please assign kow3ns
You can assign the PR to them by writing /assign @kow3ns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeblair
Copy link
Author

jeblair commented Aug 6, 2020

I'd like to take a different approach, will open a revised PR.

@jeblair jeblair closed this Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants