Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/chartmuseum] fixed name of service account #23670

Merged
merged 3 commits into from Sep 3, 2020

Conversation

ChrisCooney1
Copy link
Contributor

What this PR does / why we need it:

There is a bug in the chart museum helm chart. There is a value Values.serviceAccount.name that allows you to specify the name of your service account. This is important because the name of the service account needs to be known for IRSA role mapping. However, the helm chart always defaults to {{ include "chartmuseum.fullname" . }}.

This PR solves this with the usual conditional logic for these values.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Chris Cooney <chris.cooney1@sainsburys.co.uk>
Signed-off-by: Chris Cooney <chris.cooney1@sainsburys.co.uk>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Sep 2, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ChrisCooney1. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 2, 2020
Signed-off-by: Chris Cooney <chris.cooney1@sainsburys.co.uk>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2020
@yurrriq
Copy link
Collaborator

yurrriq commented Sep 3, 2020

/lgtm
thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChrisCooney1, yurrriq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 3, 2020
@yurrriq
Copy link
Collaborator

yurrriq commented Sep 3, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 24ae32e into helm:master Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants