This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/chartmuseum] fixed name of service account #23670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There is a bug in the chart museum helm chart. There is a value
Values.serviceAccount.name
that allows you to specify the name of your service account. This is important because the name of the service account needs to be known for IRSA role mapping. However, the helm chart always defaults to{{ include "chartmuseum.fullname" . }}
.This PR solves this with the usual conditional logic for these values.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)