Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nginx-ingress] Add support for extraContainers, extraVolumeMounts and extraVolumes #3983

Merged
merged 2 commits into from
Apr 6, 2018
Merged

[stable/nginx-ingress] Add support for extraContainers, extraVolumeMounts and extraVolumes #3983

merged 2 commits into from
Apr 6, 2018

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Mar 5, 2018

Replaces #3810.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2018
This was referenced Mar 5, 2018
Closed
Open
@paulczar
Copy link
Collaborator

I really like this pattern. Can you bump the version for a minor release as its adding features?

should be 0.12.0 based on current version.

@paulczar
Copy link
Collaborator

/assign @paulczar

paulczar
paulczar suggested changes Mar 13, 2018
View reviewed changes
Copy link
Collaborator

@paulczar paulczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this pattern. Can you bump the version for a minor release as its adding features?

should be 0.12.0 based on current version.

@paulczar
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 13, 2018
@sathieu
Copy link
Contributor Author

sathieu commented Mar 13, 2018

I have rebased and bumped the version to 0.12.0 as requested.

@sathieu
Copy link
Contributor Author

sathieu commented Mar 13, 2018

/retest

@unguiculus
Copy link
Member

/assign

paulczar
paulczar approved these changes Mar 19, 2018
View reviewed changes
Copy link
Collaborator

@paulczar paulczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paulczar
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2018
@unguiculus unguiculus mentioned this pull request Mar 19, 2018
Closed
@sathieu
Copy link
Contributor Author

sathieu commented Mar 19, 2018

/assign @unguiculus

@unguiculus unguiculus mentioned this pull request Mar 27, 2018
Closed
@paulczar
Copy link
Collaborator

@sathieu you'll need to rebase from master to fix the conflicts.

@unguiculus
Copy link
Member

Please rename: sidecarContainers-> extraContainers

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2018
@sathieu
Copy link
Contributor Author

sathieu commented Mar 30, 2018

@paulczar @unguiculus Done.

@sathieu sathieu changed the title [stable/nginx-ingress] Add support for extraVolumeMounts, sidecarContainers and extraVolumes [stable/nginx-ingress] Add support for extraContainers, extraVolumeMounts and extraVolumes Mar 30, 2018
@timstoop
Copy link
Contributor

timstoop commented Apr 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2018
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulczar, sathieu, timstoop, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit 0309100 into helm:master Apr 6, 2018
rolanddb pushed a commit to Eneco/charts that referenced this pull request Apr 9, 2018
@sathieu @rolanddb
[stable/nginx-ingress] Add support for extraContainers, extraVolumeMo…
e0295f7 
…unts and extraVolumes (helm#3983)
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
@sathieu
[stable/nginx-ingress] Add support for extraContainers, extraVolumeMo…
1e2706c 
…unts and extraVolumes (helm#3983)
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
@sathieu
[stable/nginx-ingress] Add support for extraContainers, extraVolumeMo…
8ed5fea 
…unts and extraVolumes (helm#3983)

Signed-off-by: voron <av@arilot.com>
@npepinpe npepinpe mentioned this pull request Aug 20, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulczar paulczar paulczar approved these changes

Assignees

@unguiculus unguiculus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sathieu @paulczar @unguiculus @timstoop @k8s-ci-robot