Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/sonarqube] Fix failing deployment and tests #4871

Merged
merged 1 commit into from
Apr 10, 2018
Merged

[stable/sonarqube] Fix failing deployment and tests #4871

merged 1 commit into from
Apr 10, 2018

Conversation

rjkernick
Copy link
Collaborator

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 10, 2018
@rjkernick
Copy link
Collaborator Author

/assign unguiculus

@unguiculus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 10, 2018
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjkernick, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit c00ecbd into helm:master Apr 10, 2018
@jcscottiii
Copy link
Contributor

@rjkernick Which version of k8s are you using?
When I was on 1.8.x, this PR worked fine for me.
Last night, I decided to update our cluster to 1.9.6 and this deployment broke. I kept getting Read-Only errors. Did some digging and found out that it was related to this security patch kubernetes/kubernetes#60814

Tried this PR #4787 out but it didn't work. But if i revert this patch and make the following change, it works.

@@ -115,6 +114,7 @@ spec:
           name: {{ template "sonarqube.fullname" . }}-config
       - name: install-plugins
         configMap:
+          defaultMode: 0755
           name: {{ template "sonarqube.fullname" . }}-install-plugins

But yeah, just wanted to gauge how's everything working on your side.

Examples of other charts having this problem:
#4272
#4166

@rjkernick
Copy link
Collaborator Author

I am on 1.8.x, but have also tested it on minikube with 1.9.4. I believe the helm tests run against 1.9.x as well

nazarewk pushed a commit to nazarewk/charts that referenced this pull request Apr 18, 2018
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants