-
Notifications
You must be signed in to change notification settings - Fork 16.9k
[stable/sonarqube] Fix failing deployment and tests #4871
Conversation
/assign unguiculus |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjkernick, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rjkernick Which version of k8s are you using? Tried this PR #4787 out but it didn't work. But if i revert this patch and make the following change, it works.
But yeah, just wanted to gauge how's everything working on your side. |
I am on 1.8.x, but have also tested it on minikube with 1.9.4. I believe the helm tests run against 1.9.x as well |
Signed-off-by: voron <av@arilot.com>
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: