This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Add doc about redis data only persistence #4965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Miouge1
force-pushed
the
redis-persistence-data
branch
2 times, most recently
from
2c13662
to
eb552ae
Compare
carrodher
reviewed
Apr 17, 2018
stable/redis/README.md
Outdated
| @@ -174,6 +174,8 @@ The [Bitnami Redis](https://github.com/bitnami/bitnami-docker-redis) image store | |||
|
|
|||
| By default, the chart mounts a [Persistent Volume](http://kubernetes.io/docs/user-guide/persistent-volumes/) at this location. The volume is created using dynamic volume provisioning. If a Persistent Volume Claim already exists, specify it during installation. | |||
|
|
|||
| By default, the chart persists both data and configuration. If you wish to persist only the data directory set `persistence.subPath` to `redis/data` and `persistence.path` to `/bitnami/redis/data`. | |||
There was a problem hiding this comment.
Can you use the reverse instructions? From the general to the specific:
persistence.pathto/bitnami/redis/dataandpersistence.subPathtoredis/data
instead of
persistence.subPathtoredis/dataandpersistence.pathto/bitnami/redis/data
There was a problem hiding this comment.
OK. Changed in latest commit.
|
Also, can you take a look at the conflicts? It seems new changes appears in the Chart.yml |
Miouge1
force-pushed
the
redis-persistence-data
branch
from
eb552ae
to
326cbce
Compare
|
I rebased this branch on latest master and resolved conflicts |
|
/lgtm |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carrodher, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Apr 18, 2018
goruha
added a commit
to goruha/charts
that referenced
this pull request
Apr 19, 2018
…into rabbitmq-workload-api-fix * 'rabbitmq-workload-api-fix' of github.com:goruha/charts: (75 commits) [stable/odoo] Add carrodher as owner (helm#4856) [stable/jasperreports] Release 1.0.3 (helm#5107) Add doc about redis data only persistence (helm#4965) [sentry] add nodeSelector, affinity & tolerations (helm#4264) [stable/sonarqube] Adding support for Service annotations (helm#4060) [incubator/schema-registry] Updating GroupID, and moving to using kafka coordinator master election (helm#5019) quote boolean S3 environment variables (helm#5066) Fix graceful shutdown of brokers, more settings, version bump (helm#5082) apiVersion shouldn't be hardcoded (helm#5060) [stable/phabricator] Release 1.0.4 (helm#5068) [stable/testlink] Release 1.0.5 (helm#5050) [stable/redis] fixed a typo into NOTES (helm#5070) [etcd-operator] readiness/liveness checks for operator (helm#4609) Annotations and checksum (helm#5067) Add OWNERS file to schema-registry (helm#5054) [stable/mongodb-replicaset] Use security context on pod level (helm#5055) Typo fix in sonarqube/README.md (helm#5045) Typo fix in sonatype-nexus/README.md (helm#5042) [sonarqube] nodeSelector, affinity & tolerations. also separate resoruces for plugin pod (helm#4265) [stable/sonarqube] upgrade to LTS version (6.7.3) (helm#5029) ...
ichtar
pushed a commit
to Bestmile/charts
that referenced
this pull request
May 15, 2018
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
Signed-off-by: voron <av@arilot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When changing password the
redis.confis not re-generated ifpersistence.enabled.