Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

consul - add readiness probe #56

Merged
merged 1 commit into from
Sep 9, 2016
Merged

consul - add readiness probe #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions incubator/consul/templates/consul-petset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,12 @@ spec:
- name: gossip-key
secret:
secretName: gossip-key
readinessProbe:
httpGet:
path: /v1/health/service/consul
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dumb question. Does this work with clustered consul? With the master when it was in boostrap mode, we had issues with the readinessProbe working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrislovecnm - It should work and always return details of the servers in the cluster. I haven't had an issue where it hasn't worked using this chart. Have you? Is there another endpoint that would better server as readinessProbe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah we have had a problem with that endpoint, when using DNS names for discovery.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay thanks. I'll take a look at polling another endpoint. Do you have any suggestions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did a netstat to see if Consul was listening to the port, but maybe it is the way we set it up. I don't personally like the netstat either. I will take it out for a test drive when I have a chance. But if it is working for you, we can iterate on it in incubator.

port: {{.Values.HttpPort}}
initialDelaySeconds: 10
timeoutSeconds: 1
volumeClaimTemplates:
- metadata:
name: datadir
Expand Down