Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/mysqlha] fix the creation of the replication user #6354

Merged
merged 1 commit into from Sep 7, 2018
Merged

[incubator/mysqlha] fix the creation of the replication user #6354

merged 1 commit into from Sep 7, 2018

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jun 27, 2018

What this PR does / why we need it:
Fix the issue described here: #5849
Which issue this PR fixes
fixes: #5849

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2018
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2018
@cpanato cpanato changed the title fix the creation of the replication user [incubator/mysqlha] fix the creation of the replication user Jun 27, 2018
@cpanato
Copy link
Member Author

cpanato commented Jun 27, 2018

/assign @mgoodness

@stale
Copy link

stale bot commented Aug 8, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Activing will cause the issue to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 8, 2018
@cpanato
Copy link
Member Author

cpanato commented Aug 8, 2018

Waiting for review

@stale stale bot removed the wontfix label Aug 8, 2018
@cpanato
Copy link
Member Author

cpanato commented Aug 8, 2018

ping @mgoodness
When you have some time can you please review? thanks so much!

if need help to maintain the chart please let me know

@cpanato
Copy link
Member Author

cpanato commented Aug 10, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 10, 2018
@cpanato
Copy link
Member Author

cpanato commented Aug 10, 2018

/lint

@mattfarina
Copy link
Contributor

@jpoon @jonhoare Can you please take a look at this PR?

@jpoon
Copy link
Collaborator

jpoon commented Aug 19, 2018

The only major change I see is that you've wrapped the create-replication-user.sql into a bash script, but I don't quite follow how that will resolve the issue listed in #5849.

@cpanato
Copy link
Member Author

cpanato commented Aug 19, 2018

@jpoon I did several tests and after this fix the issue never happen again. without that, it happens most of the time for me.

@mattfarina mattfarina added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2018
@davidkarlsen
Copy link
Member

@jpoon roll with it? from the logs in the issue the .sql's seems empty for some reason (maybe some tee funkiness?)
At any rate this seems just as clean?
Can you give a yay or nay?
I'll assign it and merge it in a couple of days if I don't hear anything back from you. OK?
/assign

@jpoon
Copy link
Collaborator

jpoon commented Sep 7, 2018

@davidkarlsen 🚢 it

@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, davidkarlsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit a87de92 into helm:master Sep 7, 2018
@ey-bot ey-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 7, 2018
@cpanato cpanato deleted the fix_startup_xtrabackup branch September 8, 2018 17:05
jicowan pushed a commit to jicowan/charts that referenced this pull request Oct 2, 2018
Signed-off-by: jenkin-x <jicowan@hotmail.com>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
@howudoing
Copy link

the issue still exists...

1 similar comment
@xiongleio
Copy link

the issue still exists...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[incubator/mysqlha] cannot open ./xtrabackup_checkpoints and cannot find ./xtrabackup_logfile
9 participants