[stable/kured] Add initial chart #6470
Conversation
k8s-ci-robot
added
needs-ok-to-test
k8s-ci-robot
added
the
cncf-cla: yes
incubator/kured/Chart.yaml
Outdated
| @@ -0,0 +1,5 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
add sources, home and maintainers
There was a problem hiding this comment.
Added home and maintainers as per https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md#chart-metadata, but that doesn't mention sources - what should that be?
There was a problem hiding this comment.
sources should point to the home of kured. maybe it is optional - but it is handy
There was a problem hiding this comment.
Gotcha, added sources to just point to the same github
| @@ -0,0 +1,57 @@ | |||
| apiVersion: extensions/v1beta1 | |||
There was a problem hiding this comment.
should this be apps/v1? https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/
There was a problem hiding this comment.
Agreed. Changed and tested, still works.
| @@ -0,0 +1,5 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
should this be conditional on rbac.create too?
|
/assign @mgoodness |
|
/assign @prydonius |
|
I think this can go straight to stable btw. |
plumdog
changed the title
|
/assign @unguiculus |
There was a problem hiding this comment.
Please follow our RBAC best practices: https://github.com/kubernetes/helm/blob/master/docs/chart_best_practices/rbac.md
|
@unguiculus Thanks for pointing that out - I've given it a go, and it seems to work like I'd expect it to. |
|
/lgtm |
|
/lgtm cancel |
|
@davidkarlsen Have fixed the whitespace linting fail, and have added optional tolerations. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidkarlsen, plumdog, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
* [incubator/kured] Add initial chart * [incubator/kured] CR: Add home and maintainers to Chart.yaml * [incubator/kured] CR: Add sources to Chart.yaml * [incubator/kured] CR: Fix apiVersion for DaemonSet * [incubator/kured] CR: wrap ServiceAccount in rbac.create * [incubator/kured] Exlicitly set .spec.selector for the DaemonSet * [stable/kured] Move from incubator to stable * [stable/kured] CR: Update for RBAC/ServiceAccount best practices * CR: linting, remove extra space * CR: allow tolerations for daemonset Signed-off-by: Marek Bartik <mab@revolgy.com> Signed-off-by: Marek Bartik <bartimar6@gmail.com>
* [incubator/kured] Add initial chart * [incubator/kured] CR: Add home and maintainers to Chart.yaml * [incubator/kured] CR: Add sources to Chart.yaml * [incubator/kured] CR: Fix apiVersion for DaemonSet * [incubator/kured] CR: wrap ServiceAccount in rbac.create * [incubator/kured] Exlicitly set .spec.selector for the DaemonSet * [stable/kured] Move from incubator to stable * [stable/kured] CR: Update for RBAC/ServiceAccount best practices * CR: linting, remove extra space * CR: allow tolerations for daemonset Signed-off-by: aba182 <ajwilhel@gmail.com>
* [incubator/kured] Add initial chart * [incubator/kured] CR: Add home and maintainers to Chart.yaml * [incubator/kured] CR: Add sources to Chart.yaml * [incubator/kured] CR: Fix apiVersion for DaemonSet * [incubator/kured] CR: wrap ServiceAccount in rbac.create * [incubator/kured] Exlicitly set .spec.selector for the DaemonSet * [stable/kured] Move from incubator to stable * [stable/kured] CR: Update for RBAC/ServiceAccount best practices * CR: linting, remove extra space * CR: allow tolerations for daemonset Signed-off-by: aba182 <ajwilhel@gmail.com>
* [incubator/kured] Add initial chart * [incubator/kured] CR: Add home and maintainers to Chart.yaml * [incubator/kured] CR: Add sources to Chart.yaml * [incubator/kured] CR: Fix apiVersion for DaemonSet * [incubator/kured] CR: wrap ServiceAccount in rbac.create * [incubator/kured] Exlicitly set .spec.selector for the DaemonSet * [stable/kured] Move from incubator to stable * [stable/kured] CR: Update for RBAC/ServiceAccount best practices * CR: linting, remove extra space * CR: allow tolerations for daemonset Signed-off-by: Jakob Niggel <info@jakobniggel.de>
What this PR does / why we need it:
Adds a chart for kured, the kubernetes reboot daemon - https://github.com/weaveworks/kured
I took the bits of manifest in the repo linked, and chart-ified them, such that this now works for me.
Beware: this is my first contributed chart, so exercise vigilance. And I think I've read and done the bookkeeping things I need to, but I'm sure I'll have missed something.