Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/joomla] Improve notes to access deployed services #7013

Merged
merged 2 commits into from Aug 7, 2018
Merged

[stable/joomla] Improve notes to access deployed services #7013

merged 2 commits into from Aug 7, 2018

Conversation

juan131
Copy link
Collaborator

@juan131 juan131 commented Aug 6, 2018

What this PR does / why we need it:

As described on kubernetes/kubernetes#59809, now kubectl port-foward resolves service port to target port. Therefore, we can access the services deployed as 'ClusterIP' using a simple port-forward.

This PR improves the NOTES.txt so this new method is the one recommended to access the application when using 'ClusterIP'

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2018
@carrodher
Copy link
Collaborator

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carrodher, juan131

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5d60a85 into helm:master Aug 7, 2018
@juan131 juan131 deleted the joomla_notes branch August 15, 2018 12:16
marekaf pushed a commit to marekaf/charts that referenced this pull request Sep 4, 2018
* Improve notes to access deployed services

* Add namespace to port-forward command

Signed-off-by: Marek Bartik <mab@revolgy.com>
aba182 pushed a commit to aba182/charts that referenced this pull request Sep 7, 2018
* Improve notes to access deployed services

* Add namespace to port-forward command

Signed-off-by: aba182 <ajwilhel@gmail.com>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
* Improve notes to access deployed services

* Add namespace to port-forward command

Signed-off-by: Jakob Niggel <info@jakobniggel.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants