Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Promote incubator/logstash to stable #7222

Closed
wants to merge 4 commits into from
Closed

Promote incubator/logstash to stable #7222

wants to merge 4 commits into from

Conversation

rendhalver
Copy link
Collaborator

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2018
@rendhalver rendhalver mentioned this pull request Aug 16, 2018
Closed
@christian-roggia
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: christian-roggia, rendhalver
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: viglesiasce

If they are not already assigned, you can assign the PR to them by writing /assign @viglesiasce in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

davidkarlsen
davidkarlsen reviewed Aug 17, 2018
View reviewed changes
incubator/logstash/README.md Outdated
@@ -2,6 +2,8 @@

[Logstash](https://www.elastic.co/products/logstash) is an open source, server-side data processing pipeline that ingests data from a multitude of sources simultaneously, transforms it, and then sends it to your favorite “stash.”

**Note - this chart has been deprecated and [moved to stable](../../stable/burrow)**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why burrow?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is a Ctrl+C Ctrl+V gone wrong

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops.
Stoopid cut and paste

@rendhalver
Copy link
Collaborator Author

@christian-roggia It seems that we need ltgm and approve tags before this can be merged.
@unguiculus Is that intentional or am I reading that incorrectly?

@cpanato
Copy link
Member

cpanato commented Aug 23, 2018

@rendhalver the owners should /approve /lgtm since this chart there is no owners file yet, this need to be approved by the owners from the chart repo

hope it clarifies your questions

@rendhalver
Copy link
Collaborator Author

Ah that explains it @cpanato thank you.

@mattfarina mattfarina added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2018
@stale
Copy link

stale bot commented Sep 22, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2018
@rifelpet
Copy link
Contributor

/remove-lifecycle stale

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2018
davidkarlsen
davidkarlsen suggested changes Sep 22, 2018
View reviewed changes
stable/logstash/Chart.yaml
icon: https://www.elastic.co/assets/blt86e4472872eed314/logo-elastic-logstash-lt.svg
home: https://www.elastic.co/products/logstash
name: logstash
version: 0.8.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set version to 1.0.0 in the promoted repo

@davidkarlsen
Copy link
Member

@rendhalver can you fix the merge conflict (and get that chart-change over to the stable tree?)

@rendhalver
Copy link
Collaborator Author

Yep. I will get that sorted when I can.

rendhalver pushed a commit to powerhome/kubernetes-charts that referenced this pull request Oct 15, 2018
Promote logstash to stable
19c1d95 
Redo of helm#7222

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>
@rendhalver rendhalver mentioned this pull request Oct 15, 2018
Merged
3 tasks
@rendhalver
Copy link
Collaborator Author

Closing in favour of #8479

@rendhalver rendhalver closed this Oct 15, 2018
@rendhalver rendhalver deleted the logstash-to-stable branch October 15, 2018 18:17
k8s-ci-robot pushed a commit that referenced this pull request Oct 16, 2018
@rendhalver @k8s-ci-robot
Promote logstash to stable (#8479)
0eaf498 
* Promote logstash to stable

Redo of #7222

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>

* Update version of logstash

Fix references in readme

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>
darioblanco pushed a commit to minddocdev/charts that referenced this pull request Oct 22, 2018
@rendhalver
Promote logstash to stable (helm#8479)
4e32d4c 
* Promote logstash to stable

Redo of helm#7222

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>

* Update version of logstash

Fix references in readme

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>
emas80 pushed a commit to faceit/charts that referenced this pull request Oct 24, 2018
@rendhalver @emas80
Promote logstash to stable (helm#8479)
214d868 
* Promote logstash to stable

Redo of helm#7222

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>

* Update version of logstash

Fix references in readme

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
@rendhalver @Jnig
Promote logstash to stable (helm#8479)
a5cf23b 
* Promote logstash to stable

Redo of helm#7222

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>

* Update version of logstash

Fix references in readme

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@rendhalver @wgiddens
Promote logstash to stable (helm#8479)
7f18a87 
* Promote logstash to stable

Redo of helm#7222

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>

* Update version of logstash

Fix references in readme

Signed-off-by: Pete Brown <pete.brown@powerhrg.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidkarlsen davidkarlsen davidkarlsen requested changes

@christian-roggia christian-roggia Awaiting requested review from christian-roggia

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rendhalver @christian-roggia @k8s-ci-robot @cpanato @rifelpet @davidkarlsen @mattfarina