Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Ansible AWX to charts (fix PR #6106) #8085

Closed
wants to merge 33 commits into from

Conversation

@joaocc
Copy link
Contributor

commented Oct 1, 2018

This PR fixes one the last missing points of #6106, namely, the use of non-stable image versions.

Najeongho added some commits Jun 14, 2018

Update AWX Chart (#6106)
* Fixing Chart version

* Update AWX charts

* Update README.md

* Update AWX chart

* Update values.yaml

* Updated this chart to correspond with Helm 2.8+ version and guidelines and best practices

* Update docs version

* Update an indent.
Update AWX Chart (#6106)
* Fixing Chart version

* Update AWX charts

* Update README.md

* Update AWX chart

* Update values.yaml

* Updated this chart to correspond with Helm 2.8+ version and guidelines and best practices

* Update docs version

* Update an indent.
Update AWX Chart (#6106)
* Fixing Chart version

* Update AWX charts

* Update README.md

* Update AWX chart

* Update values.yaml

* Updated this chart to correspond with Helm 2.8+ version and guidelines and best practices

* Update docs version

* Update an indent.
Update AWX Chart (#6106)
* Fixing Chart version

* Update AWX charts

* Update README.md

* Update AWX chart

* Update values.yaml

* Updated this chart to correspond with Helm 2.8+ version and guidelines and best practices

* Update docs version

* Update an indent.
Update AWX Chart (#6106)
* Fixing Chart version

* Update AWX charts

* Update README.md

* Update AWX chart

* Update values.yaml

* Updated this chart to correspond with Helm 2.8+ version and guidelines and best practices

* Update docs version

* Update an indent.
Update AWX Chart (#6106)
* Fixing Chart version

* Update AWX charts

* Update README.md

* Update AWX chart

* Update values.yaml

* Updated this chart to correspond with Helm 2.8+ version and guidelines and best practices

* Update docs version

* Update an indent.
Update AWX Chart (#6106)
* Fixing Chart version

* Update AWX charts

* Update README.md

* Update AWX chart

* Update values.yaml

* Updated this chart to correspond with Helm 2.8+ version and guidelines and best practices

* Update docs version

* Update an indent.
Update AWX Chart (#6106)
* Fixing Chart version

* Update AWX charts

* Update README.md

* Update values.yaml

* Updated this chart to correspond with Helm 2.8+ version and guidelines and best practices

* Update docs version
Update AWX Chart (#6106)
* Update template

* Fixing Chart version

Najeongho and others added some commits Aug 16, 2018

@k8s-ci-robot k8s-ci-robot requested review from mgoodness and scottrigby Oct 1, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joaocc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: scottrigby

If they are not already assigned, you can assign the PR to them by writing /assign @scottrigby in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2018

Hi @joaocc. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joaocc joaocc changed the title Trying to fix https://github.com/helm/charts/pull/6106 Request for Ansible AWX to charts (fix PR #6106) Oct 1, 2018

@joaocc

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2018

I'm not sure how to add just 1 commit to an existing PR.
I just found out that doing it this way requires me to DCO all commits from @Najeongho.
Suggestions on how to unblock the previous PR are welcomed

@stale

This comment has been minimized.

Copy link

commented Oct 31, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Oct 31, 2018

@stale

This comment has been minimized.

Copy link

commented Nov 14, 2018

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.