This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/osclass] Add apache exporter #8850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com>
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
needs-ok-to-test
carrodher
suggested changes
Oct 30, 2018
| @@ -19,13 +19,26 @@ spec: | |||
| app: {{ template "osclass.fullname" . }} | |||
| chart: "{{ .Chart.Name }}-{{ .Chart.Version }}" | |||
| release: "{{ .Release.Name }}" | |||
| {{- if or .Values.podAnnotations .Values.metrics.enabled }} | |||
There was a problem hiding this comment.
podAnnotation is not defined in values.yaml (and values-production.yaml if it exists).
Can you add it and also include the new variable in the README?
Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com>
helm-bot
added
size/M
Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com>
helm-bot
added
size/M
|
/ok-to-test |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carrodher, javsalgar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
pmontanari
pushed a commit
to pmontanari/charts
that referenced
this pull request
Nov 2, 2018
* [stable/osclass] Add apache exporter Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> * [stable/osclass] Add podAnnotations Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> * [stable/osclass] Add podAnnotations Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> Signed-off-by: Patrick Montanari <patrick.montanari@gmail.com>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
* [stable/osclass] Add apache exporter Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> * [stable/osclass] Add podAnnotations Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> * [stable/osclass] Add podAnnotations Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
* [stable/osclass] Add apache exporter Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> * [stable/osclass] Add podAnnotations Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> * [stable/osclass] Add podAnnotations Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds an Apache exporter to be used with Prometheus.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]