This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/redis] Fix ServiceMonitor to not leak. #9722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
approved
|
@desaintmartin can you fix the mergeconflict? |
|
/ok-to-test |
Previous definition allowed Prometheus to scrape all redis in all namespaces. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
helm-bot
added
size/S
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carrodher, desaintmartin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
anapsix
added a commit
to anapsix/charts
that referenced
this pull request
Dec 5, 2018
…-chown-failure * origin/master: (58 commits) [stable/redis] Fix ServiceMonitor to not leak. (helm#9722) Add existingSecret configuration key to postgresql chart (helm#9729) [stable/metallb] fix typo for privileges (helm#9734) upgrade elasticsearch to 6.5.1 (helm#9685) upgrade grafana (helm#9692) upgrade external-dns (helm#9725) [incubator/cassandra] update backup tag to enable file streaming (helm#9718) [stable/moodle] Release 4.0.2 (helm#9732) [stable/ghost] Release 6.1.4 (helm#9726) [stable/postgresql] Merge metrics into master statefulset as sidecar. (helm#9574) Update Minio and mc versions (helm#9531) Add @nitisht and @wlan0 as Trusted Collaborators (helm#9704) [stable/karma] add myself to the OWNERS file (helm#9737) [stable/kured] Add pod annotations (helm#9736) [stable/karma] update to v0.18 (helm#9730) [stable/fluent-bit] Revert to og indentation... or Refactor configuration (helm#9008) Deprecating keel chart in preparation for the new Helm Distributed repo (hub). (helm#9514) Update MetalLB README.md and values.yaml (helm#9023) [stable/sonarqube] Upgrade chart for new sonarqube images (helm#9721) Upgrading to v0.4.0 (helm#9711) ...
yuchaoran2011
pushed a commit
to yuchaoran2011/charts
that referenced
this pull request
Dec 11, 2018
Previous definition allowed Prometheus to scrape all redis in all namespaces. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com>
coreypobrien
pushed a commit
to FairwindsOps/helm-charts
that referenced
this pull request
Dec 31, 2018
Previous definition allowed Prometheus to scrape all redis in all namespaces. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
Previous definition allowed Prometheus to scrape all redis in all namespaces. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous definition allowed Prometheus to scrape all redis in all namespaces.
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]