ref(*): Use HELMC_HOME instead of HELM_HOME #460
Conversation
| @@ -20,6 +20,9 @@ func Generate(chart, homedir string, exclude []string, force bool) { | |||
| } | |||
| chartPath := util.WorkspaceChartDirectory(homedir, chart) | |||
|
|
|||
| // Although helmc itself may use the new HELMC_HOME environment variable to optionally define its | |||
| // home directory, to maintain compatibility with charts created for the ORIGINAL helm, we | |||
| // continue to support expansion of these "legacy" environment variables, including HELM_HOME. | |||
| os.Setenv("HELM_HOME", homedir) | |||
| os.Setenv("HELM_DEFAULT_REPO", mustConfig(homedir).Repos.Default) | |||
| os.Setenv("HELM_FORCE_FLAG", strconv.FormatBool(force)) | |||
There was a problem hiding this comment.
shouldn't we be setting the values for the HELMC_HOME and others so that when new charts are created and uses $HELMC_HOME it works?
There was a problem hiding this comment.
New charts should continue to use HELM_HOME. If people start using HELMC_HOME in charts, those charts won't work with older / original helm. This is addressed in the updated documentation I have also PR'ed. It ensures both backwards and forwards compatibility.
Re: whether we might want to additionally set HELMC_HOME, I believe the answer is no. Existing environment variables do get expanded here. This means if someone has HELMC_HOME set to a custom value, it will be properly inherited and interpreted by any possible invocation of the helmc binary in the generator header. If it is absent, the invocation of the helmc binary in the generator header will use the default helmc home dir, just as the initial invocation of helmc (by the user) would have.
The only thing we'd gain by setting HELMC_HOME is that chart authors would be able to use it for some custom command like the following:
#helm:generate sed -i s/foo/bar/ $HELMC_HOME/blah/blah
And that is precisely the thing we don't want chart authors doing because it will break their chart's compatibility with older / original helm. I feel that if we don't want them doing that, we shouldn't encourage that mistake by unnecessarily injecting a value into the HELMC_HOME env var when generators are invoked.
fix(validate-go): show the errors gofmt found
Fixes #459
cc @kmala