Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected the JFrog Artifactory link #1575

Merged
merged 2 commits into from
May 6, 2024

Conversation

Copy link
Contributor

@angellk angellk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome - thanks @nagarajuv-jfrog !

@angellk
Copy link
Contributor

angellk commented Apr 12, 2024

@nagarajuv-jfrog please review the DCO instructions:
https://github.com/helm/helm-www/pull/1575/checks?check_run_id=23738966358

Once that is fixed, we can merge!

@nagarajuv-jfrog
Copy link
Contributor Author

@nagarajuv-jfrog please review the DCO instructions: https://github.com/helm/helm-www/pull/1575/checks?check_run_id=23738966358

Once that is fixed, we can merge!

I've difficulty fixing it.

2096132 > I've made another commit with this commit id. It contains sign-off details.

Is it okay?

@yxxhero
Copy link
Member

yxxhero commented Apr 18, 2024

@nagarajuv-jfrog please fix DCO issue.

@yxxhero
Copy link
Member

yxxhero commented Apr 18, 2024

git rebase HEAD~2 --signoff
git push --force-with-lease origin updating-JFrog-Artifactory

@nagarajuv-jfrog
Copy link
Contributor Author

Upon following the above instructions, I'm getting this error >>ERROR: Permission to helm/helm-www.git denied to nagarajuv-jfrog.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@nagarajuv-jfrog
Copy link
Contributor Author

Upon following the above instructions, I'm getting this error >>ERROR: Permission to helm/helm-www.git denied to nagarajuv-jfrog. fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

@angellk | @yxxhero

Is there any possibility that one of you can make the changes on our behalf?

I also tried to open a new PR but facing issues related to authentication. Same is the case when one of our colleagues tried this.

Please suggest how to proceed with this.

@yxxhero
Copy link
Member

yxxhero commented May 6, 2024

@yxxhero
Copy link
Member

yxxhero commented May 6, 2024

In your local branch, run: git rebase HEAD~2 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin updating-JFrog-Artifactory

@nagarajuv-jfrog
Copy link
Contributor Author

Upon following the above instructions, I'm getting this error >>ERROR: Permission to helm/helm-www.git denied to nagarajuv-jfrog. fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

Upon following the above instructions, I'm getting this error >>ERROR: Permission to helm/helm-www.git denied to nagarajuv-jfrog.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@yxxhero
Copy link
Member

yxxhero commented May 6, 2024

@yxxhero
Copy link
Member

yxxhero commented May 6, 2024

@nagarajuv-jfrog

Signed-off-by: nagarajuv <nagarajuv@jfrog.com>
Signed-off-by: nagarajuv <nagarajuv@jfrog.com>
@nagarajuv-jfrog
Copy link
Contributor Author

https://github.com/nagarajuv-jfrog/helm-www/tree/updating-JFrog-Artifactory please push to the address.

@yxxhero ,

Ohh finally!

It worked. Thanks a lot!

Could you please approve?

@yxxhero yxxhero merged commit 5a5e5b7 into helm:main May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants