Skip to content

Commit

Permalink
fix(helm): fix the build-time golint warning on 'cmd/helm/install.go'
Browse files Browse the repository at this point in the history
When building helm, golint no longer generates the following warning:

cmd/helm/install.go:502:9:warning: if block ends with a return statement, so drop this else and outdent its block (golint)

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
  • Loading branch information
adshmh committed Feb 8, 2018
1 parent 6a1dd80 commit 244b1b1
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions cmd/helm/install.go
Expand Up @@ -499,12 +499,12 @@ func readFile(filePath string) ([]byte, error) {

if err != nil {
return ioutil.ReadFile(filePath)
} else {
getter, err := getterConstructor(filePath, "", "", "")
if err != nil {
return []byte{}, err
}
data, err := getter.Get(filePath)
return data.Bytes(), err
}

getter, err := getterConstructor(filePath, "", "", "")
if err != nil {
return []byte{}, err
}
data, err := getter.Get(filePath)
return data.Bytes(), err
}

0 comments on commit 244b1b1

Please sign in to comment.