Skip to content

Commit

Permalink
fix(helm): fail when helm deps are not fetched
Browse files Browse the repository at this point in the history
This changes the behavior of the bulk downloader to fail as soon as it
encounters a dependency that it cannot fetch.

Closes #1439
  • Loading branch information
technosophos committed Oct 26, 2016
1 parent 5ea81b4 commit 5dfbf7e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions cmd/helm/downloader/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,15 +194,15 @@ func (m *Manager) downloadAll(deps []*chartutil.Dependency) error {
for _, dep := range deps {
fmt.Fprintf(m.Out, "Downloading %s from repo %s\n", dep.Name, dep.Repository)

// Any failure to resolve/download a chart should fail:
// https://github.com/kubernetes/helm/issues/1439
churl, err := findChartURL(dep.Name, dep.Version, dep.Repository, repos)
if err != nil {
fmt.Fprintf(m.Out, "WARNING: %s (skipped)", err)
continue
return fmt.Errorf("could not find %s: %s", churl, err)
}

if _, _, err := dl.DownloadTo(churl, "", destPath); err != nil {
fmt.Fprintf(m.Out, "WARNING: Could not download %s: %s (skipped)", churl, err)
continue
return fmt.Errorf("could not download %s: %s", churl, err)
}
}
return nil
Expand Down

0 comments on commit 5dfbf7e

Please sign in to comment.