-
Notifications
You must be signed in to change notification settings - Fork 7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add --burst-limit option for client-side throttling limit configurati…
…on (#10842) * feat: add configuration for client-side throttling limit Client-side throttling seems to be an issue in larger environments such as OpenShift clusters, where it is common to have several hundreds CRDs out-of-the-box. From this view point, it is fair that clients should be able to fine tune this accordingly should the environment they work on evolves, which is currently not possible, and quite frustrating. This change introduces the --default-burst-limit option to helm (and its counterpart HELM_DEFAULT_BURST_LIMIT environment variable) to address that issue, allowing clients to properly tune their client usage as their environment evolves. Signed-off-by: Igor Sutton <isuttonl@redhat.com> * chore: change DefaultBurstLimit to BurstLimit Signed-off-by: Igor Sutton <isuttonl@redhat.com> * chore: add HELM_BURST_LIMIT to golden file Signed-off-by: Igor Sutton <isuttonl@redhat.com> * chore: add burst limit tests Signed-off-by: Igor Sutton <isuttonl@redhat.com> * docs: add burst limit default value to documentation Signed-off-by: Igor Sutton <isuttonl@redhat.com> * refactor: change burst limit default value to 100 per review instructions Signed-off-by: Igor Sutton <isuttonl@redhat.com>
- Loading branch information
Igor Sutton
committed
May 17, 2022
1 parent
c05bf27
commit 823d929
Showing
4 changed files
with
49 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
HELM_BIN | ||
HELM_BURST_LIMIT | ||
HELM_CACHE_HOME | ||
HELM_CONFIG_HOME | ||
HELM_DATA_HOME | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters