Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix race condition in
helm list
(#4620)
* Fix race in helm list when partitioning Problem: The chunks slice that is passed through the channel is reused for each partition. This means that encoding the release into a message is racing with populating the next partition, causing the results to sometimes not fit in the message, and the release list to be incorrect Solution: Allocate a new slice for each partition Issue #3322 Signed-off-by: Brian Marshall <bmarshall13@users.noreply.github.com> (cherry picked from commit a0858e2) * fix import sorting Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com> * ref(release_server_test): use NewReleaseServer() Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com> * add unit test for race condition in `helm list` Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com> (cherry picked from commit 5b23632)
- Loading branch information
Matthew Fisher
committed
Sep 10, 2018
1 parent
67b142a
commit 8d40887
Showing
3 changed files
with
30 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters