Skip to content

Commit

Permalink
fix(helm): add line feed between --values and --set data
Browse files Browse the repository at this point in the history
Currently, --set simply appends data to the end of the existing values
YAML data. If a values file does not have a line feed at the end, the
set data is mis-appended. This fixes the issue by inserting a linefeed
between the --values data and --set data.

Closes #1430
  • Loading branch information
technosophos committed Oct 21, 2016
1 parent 2eed3f0 commit 973ed17
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions cmd/helm/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,10 @@ func (i *installCmd) vals() ([]byte, error) {
return []byte{}, err
}
buffer.Write(bytes)

// Force a new line. An extra won't matter, but a missing one can
// break things. https://github.com/kubernetes/helm/issues/1430
buffer.WriteRune('\n')
}

// User specified value pairs via --set
Expand Down

0 comments on commit 973ed17

Please sign in to comment.