Skip to content

Commit

Permalink
fix: helm rollback err tips
Browse files Browse the repository at this point in the history
Signed-off-by: ithrael <wh01096045@gmail.com>
  • Loading branch information
Ithrael committed Aug 19, 2023
1 parent 37cc2fa commit db9460c
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions pkg/action/rollback.go
Expand Up @@ -110,6 +110,24 @@ func (r *Rollback) prepareRollback(name string) (*release.Release, *release.Rele
previousVersion = currentRelease.Version - 1
}

historyReleases, err := r.cfg.Releases.History(name)
if err != nil {
return nil, nil, err
}

// Check if the history version to be rolled back exists
previousVersionExist := false
for _, historyRelease := range historyReleases {
version := historyRelease.Version
if previousVersion == version {
previousVersionExist = true
break
}
}
if !previousVersionExist {
return nil, nil, errors.Errorf("release has no %d version", previousVersion)
}

r.cfg.Log("rolling back %s (current: v%d, target: v%d)", name, currentRelease.Version, previousVersion)

previousRelease, err := r.cfg.Releases.Get(name, previousVersion)
Expand Down

0 comments on commit db9460c

Please sign in to comment.