Skip to content

Commit

Permalink
Fixing build issue where wrong version is used
Browse files Browse the repository at this point in the history
The release process had selected the tag to use as the version
automatically. But, this presented a problem when a release
candidate and final release pointed to the same commit id. For a
long time it had automatically selected the final release. But,
we ran into a problem where it selected the RC tag instead of the
final release.

This change explicitly tells the build scripts the version to use
based on the tag passed into the CI run. It should no longer try
to self discover the version.

Closes #13040

Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 0b64775)
  • Loading branch information
mattfarina committed May 23, 2024
1 parent c4e37b3 commit e211f2a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
run: |
set -eu -o pipefail
make build-cross
make build-cross VERSION="${{ github.ref_name }}"
make dist checksum VERSION="${{ github.ref_name }}"
- name: Set latest version
Expand Down

0 comments on commit e211f2a

Please sign in to comment.