Skip to content

Commit

Permalink
Repair failing unit tests - failure caused by os.Stat return values f…
Browse files Browse the repository at this point in the history
…or directory size on Linux.

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
  • Loading branch information
pmacik committed Dec 9, 2019
1 parent 65bdd0c commit e3976ab
Showing 1 changed file with 16 additions and 17 deletions.
33 changes: 16 additions & 17 deletions pkg/chartutil/expand_test.go
Expand Up @@ -39,19 +39,6 @@ func TestExpand(t *testing.T) {
t.Fatal(err)
}

files, err := ioutil.ReadDir(dest)
if err != nil {
t.Fatalf("error reading output directory %s: %s", dest, err)
}

if len(files) != 1 {
t.Fatalf("expected a single chart directory in output directory %s", dest)
}

if !files[0].IsDir() {
t.Fatalf("expected a chart directory in output directory %s", dest)
}

expectedChartPath := filepath.Join(dest, "frobnitz")
fi, err := os.Stat(expectedChartPath)
if err != nil {
Expand Down Expand Up @@ -81,8 +68,14 @@ func TestExpand(t *testing.T) {
if err != nil {
t.Fatal(err)
}
if fi.Size() != expect.Size() {
t.Errorf("Expected %s to have size %d, got %d", fi.Name(), expect.Size(), fi.Size())
// os.Stat can return different values for directories, based on the OS
// for Linux, for example, os.Stat alwaty returns the size of the directory
// (value-4096) regardless of the size of the contents of the directory
mode := expect.Mode()
if !mode.IsDir() {
if fi.Size() != expect.Size() {
t.Errorf("Expected %s to have size %d, got %d", fi.Name(), expect.Size(), fi.Size())
}
}
}
}
Expand Down Expand Up @@ -127,8 +120,14 @@ func TestExpandFile(t *testing.T) {
if err != nil {
t.Fatal(err)
}
if fi.Size() != expect.Size() {
t.Errorf("Expected %s to have size %d, got %d", fi.Name(), expect.Size(), fi.Size())
// os.Stat can return different values for directories, based on the OS
// for Linux, for example, os.Stat alwaty returns the size of the directory
// (value-4096) regardless of the size of the contents of the directory
mode := expect.Mode()
if !mode.IsDir() {
if fi.Size() != expect.Size() {
t.Errorf("Expected %s to have size %d, got %d", fi.Name(), expect.Size(), fi.Size())
}
}
}
}

0 comments on commit e3976ab

Please sign in to comment.