Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: dependent chart secrets keys deleted on helm upgrade #1210

Closed
migmartri opened this issue Sep 16, 2016 · 0 comments · Fixed by #1385
Closed

Bug: dependent chart secrets keys deleted on helm upgrade #1210

migmartri opened this issue Sep 16, 2016 · 0 comments · Fixed by #1385
Assignees
Milestone

Comments

@migmartri
Copy link
Contributor

migmartri commented Sep 16, 2016

After executing helm upgrade, the keys contained in the dependent MariaDB chart k8s secret file get removed.

To reproduce:

Install for example this Wordpress Chart

You will get two secret files with two keys each.

$ kubectl describe secrets muddled-mink-mariadb muddled-mink-wordpress 
Name:           muddled-mink-mariadb
Namespace:      chart-test
Labels:         app=muddled-mink-mariadb
                chart=mariadb-0.3.0
                heritage=Tiller
                release=muddled-mink
Annotations:    <none>

Type:   Opaque

Data
====
mariadb-password:       0 bytes
mariadb-root-password:  0 bytes


Name:           muddled-mink-wordpress
Namespace:      chart-test
Labels:         app=muddled-mink-wordpress
                chart=wordpress-0.3.0
                heritage=Tiller
                release=muddled-mink
Annotations:    <none>

Type:   Opaque

Data
====
smtp-password:          0 bytes
wordpress-password:     7 bytes

Run an upgrade

helm upgrade muddled-mink .
  • Two keys from the MariaDB secret file have being removed.
  • One key from the Wordpress file was removed too.
kubectl describe secrets muddled-mink-mariadb muddled-mink-wordpress 
Name:           muddled-mink-mariadb
Namespace:      chart-test
Labels:         app=muddled-mink-mariadb
                chart=mariadb-0.3.0
                heritage=Tiller
                release=muddled-mink
Annotations:    <none>

Type:   Opaque

Data
====


Name:           muddled-mink-wordpress
Namespace:      chart-test
Labels:         app=muddled-mink-wordpress
                chart=wordpress-0.3.0
                heritage=Tiller
                release=muddled-mink
Annotations:    <none>

Type:   Opaque

Data
====
wordpress-password:     7 bytes

And this is the error if you try to re-create the MariaDB pod.

Error syncing pod, skipping: failed to "StartContainer" for "muddled-mink-mariadb" with RunContainerError: "GenerateRunContainerOptions: Couldn't find key mariadb-root-password in Secret default/muddled-mink-mariadb"

I am not sure if this behavior affect other entities like ConfigMaps.

@migmartri migmartri changed the title Bug: dependant chart secrets keys deleted on helm upgrade Bug: dependent chart secrets keys deleted on helm upgrade Sep 16, 2016
@technosophos technosophos added this to the 2.0.0-Beta.1 milestone Oct 7, 2016
@michelleN michelleN self-assigned this Oct 10, 2016
michelleN pushed a commit to michelleN/helm that referenced this issue Oct 17, 2016
This resolves helm#1210. Update will find current resource
by name and kind for comparison purposes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants