Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm test --logs errors out when tests include non-Pod resources #6968

Closed
jlegrone opened this issue Nov 14, 2019 · 2 comments
Closed

helm test --logs errors out when tests include non-Pod resources #6968

jlegrone opened this issue Nov 14, 2019 · 2 comments
Labels
bug Categorizes issue or PR as related to a bug. Stale v3.x Issues and Pull Requests related to the major version v3

Comments

@jlegrone
Copy link
Member

Output of helm version: 3.0.0

The helm test --logs implementation assumes that tests are always defined as Pods, which is no longer the case in Helm 3. We should support getting logs for Jobs, and not return an error when we encounter a resource that is neither a Pod nor a Job.

Relevant PR: #6693

@jlegrone jlegrone added bug Categorizes issue or PR as related to a bug. v3.x Issues and Pull Requests related to the major version v3 labels Nov 14, 2019
@deneuv34
Copy link

Hi @jlegrone, can I try solve this issue? 😃

@github-actions
Copy link

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug. Stale v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Development

No branches or pull requests

2 participants